|
Description
Nick Clemens (kidclamp)
2023-05-26 10:58:29 UTC
Created attachment 151754 [details] [review] Bug 33845: Display hold notes in staff client circulation paes This patch adds the reservenotes column to svc holds, and ensures they display on circulation and memeber details To test: 1 - Enable system preference 'OpacHoldNotes' 2 - Place a hold for a ptron via the OPAC 3 - View the patron in the staff client 4 - Click on the 'Holds' tab 5 - Ensure you can see the hold note 6 - Click on the 'Circulation' tab on the left 7 - Click the 'Holds' tab and confirm you can view the note Created attachment 151755 [details] [review] Bug 33845: Display hold notes in OPAC This patch adds the holds notes to the patron's account holds list 1 - Ensure system preference 'OpacHoldNotes' is enabled 2 - Place a hold on the OPAC and add a note 3 - Confirm the note displays on the Summary page Holds tab of 'Your account' 4 - In staff client, disable system preference 'OpacHoldNotes' 5 - View Holds on patron's account in opac 6 - Confirm the note no longer shows Created attachment 151756 [details] [review] Bug 33845: Use table settings and hide note by default This patch updates the holds table on circulation and moremembers to use table settings and hides the note column by default to preserve existing views To test: 1 - Apply patch 2 - Enable system preferece 'OpacHoldNotes' 3 - Place a hold on the opac and enter a note 4 - Confirm it shows on the patron's page 5 - View the patron in staff client 6 - Ensure the holds note does not display on Holds tab in Checkout or Details view 7 - Go to Admin->Table settings->Circulation 8 - Under holds_table confirm 'notes' is hidden by default 9 - Uncheck the box 10 - Refresh patron pages and confirm hold note shows Created attachment 151757 [details] [review] Bug 33845: (follow-up) escape hold notes for display Created attachment 151765 [details] [review] Bug 33845: Display hold notes in staff client circulation paes This patch adds the reservenotes column to svc holds, and ensures they display on circulation and memeber details To test: 1 - Enable system preference 'OpacHoldNotes' 2 - Place a hold for a ptron via the OPAC 3 - View the patron in the staff client 4 - Click on the 'Holds' tab 5 - Ensure you can see the hold note 6 - Click on the 'Circulation' tab on the left 7 - Click the 'Holds' tab and confirm you can view the note Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Created attachment 151766 [details] [review] Bug 33845: Display hold notes in OPAC This patch adds the holds notes to the patron's account holds list 1 - Ensure system preference 'OpacHoldNotes' is enabled 2 - Place a hold on the OPAC and add a note 3 - Confirm the note displays on the Summary page Holds tab of 'Your account' 4 - In staff client, disable system preference 'OpacHoldNotes' 5 - View Holds on patron's account in opac 6 - Confirm the note no longer shows Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Created attachment 151767 [details] [review] Bug 33845: Use table settings and hide note by default This patch updates the holds table on circulation and moremembers to use table settings and hides the note column by default to preserve existing views To test: 1 - Apply patch 2 - Enable system preferece 'OpacHoldNotes' 3 - Place a hold on the opac and enter a note 4 - Confirm it shows on the patron's page 5 - View the patron in staff client 6 - Ensure the holds note does not display on Holds tab in Checkout or Details view 7 - Go to Admin->Table settings->Circulation 8 - Under holds_table confirm 'notes' is hidden by default 9 - Uncheck the box 10 - Refresh patron pages and confirm hold note shows Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Created attachment 151768 [details] [review] Bug 33845: (follow-up) escape hold notes for display Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> 2 things:
1) Is this correct?
+ holdsTable = KohaTable("holds-table", {
+ table_settings_holds_table = [% TablesSettings.GetTableSettings( 'circ', 'circulation', 'holds_table', 'json' ) | $raw %]
We have holds-table and holds_table.
2) The holds table doesn't show the columns/export/configure buttons, but should it not?
3) For the checkouts table we have 2 separate configuration tables. Not sure if this is needed, but should we be consistent? (not a blocker)
Otherwise this works pretty well and I think it will be quite helpful.
Created attachment 152046 [details] [review] Bug 33845: (follow-up) Rename config and add a second configuration section This patch renames the table in the columns configuration to match the id used in the templates It also adds a section for the moremember table to alllow config of each page as we do for issues Lastly we add the table controls as they exist on the issues tables - holds_table: + holds-table: It feels like you need to provide an atomic update to adjust the columns_settings in DB, don't you think? (In reply to Jonathan Druart from comment #11) > - holds_table: > + holds-table: > > It feels like you need to provide an atomic update to adjust the > columns_settings in DB, don't you think? Change status to FQA if patches still need attention. Created attachment 156416 [details] [review] Bug 33845: Display hold notes in staff client circulation paes This patch adds the reservenotes column to svc holds, and ensures they display on circulation and memeber details To test: 1 - Enable system preference 'OpacHoldNotes' 2 - Place a hold for a ptron via the OPAC 3 - View the patron in the staff client 4 - Click on the 'Holds' tab 5 - Ensure you can see the hold note 6 - Click on the 'Circulation' tab on the left 7 - Click the 'Holds' tab and confirm you can view the note Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Created attachment 156417 [details] [review] Bug 33845: Display hold notes in OPAC This patch adds the holds notes to the patron's account holds list 1 - Ensure system preference 'OpacHoldNotes' is enabled 2 - Place a hold on the OPAC and add a note 3 - Confirm the note displays on the Summary page Holds tab of 'Your account' 4 - In staff client, disable system preference 'OpacHoldNotes' 5 - View Holds on patron's account in opac 6 - Confirm the note no longer shows Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Created attachment 156418 [details] [review] Bug 33845: Use table settings and hide note by default This patch updates the holds table on circulation and moremembers to use table settings and hides the note column by default to preserve existing views To test: 1 - Apply patch 2 - Enable system preferece 'OpacHoldNotes' 3 - Place a hold on the opac and enter a note 4 - Confirm it shows on the patron's page 5 - View the patron in staff client 6 - Ensure the holds note does not display on Holds tab in Checkout or Details view 7 - Go to Admin->Table settings->Circulation 8 - Under holds_table confirm 'notes' is hidden by default 9 - Uncheck the box 10 - Refresh patron pages and confirm hold note shows Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Created attachment 156419 [details] [review] Bug 33845: (follow-up) escape hold notes for display Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Created attachment 156420 [details] [review] Bug 33845: (follow-up) Rename config and add a second configuration section This patch renames the table in the columns configuration to match the id used in the templates It also adds a section for the moremember table to alllow config of each page as we do for issues Lastly we add the table controls as they exist on the issues tables Created attachment 156421 [details] [review] Bug 33845: Tidy and add update Created attachment 156692 [details] [review] Bug 33845: Display hold notes in staff client circulation paes This patch adds the reservenotes column to svc holds, and ensures they display on circulation and memeber details To test: 1 - Enable system preference 'OpacHoldNotes' 2 - Place a hold for a ptron via the OPAC 3 - View the patron in the staff client 4 - Click on the 'Holds' tab 5 - Ensure you can see the hold note 6 - Click on the 'Circulation' tab on the left 7 - Click the 'Holds' tab and confirm you can view the note Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 156693 [details] [review] Bug 33845: Display hold notes in OPAC This patch adds the holds notes to the patron's account holds list 1 - Ensure system preference 'OpacHoldNotes' is enabled 2 - Place a hold on the OPAC and add a note 3 - Confirm the note displays on the Summary page Holds tab of 'Your account' 4 - In staff client, disable system preference 'OpacHoldNotes' 5 - View Holds on patron's account in opac 6 - Confirm the note no longer shows Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 156694 [details] [review] Bug 33845: Use table settings and hide note by default This patch updates the holds table on circulation and moremembers to use table settings and hides the note column by default to preserve existing views To test: 1 - Apply patch 2 - Enable system preferece 'OpacHoldNotes' 3 - Place a hold on the opac and enter a note 4 - Confirm it shows on the patron's page 5 - View the patron in staff client 6 - Ensure the holds note does not display on Holds tab in Checkout or Details view 7 - Go to Admin->Table settings->Circulation 8 - Under holds_table confirm 'notes' is hidden by default 9 - Uncheck the box 10 - Refresh patron pages and confirm hold note shows Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 156695 [details] [review] Bug 33845: (follow-up) escape hold notes for display Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 156696 [details] [review] Bug 33845: (follow-up) Rename config and add a second configuration section This patch renames the table in the columns configuration to match the id used in the templates It also adds a section for the moremember table to alllow config of each page as we do for issues Lastly we add the table controls as they exist on the issues tables Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 156697 [details] [review] Bug 33845: Tidy and add update Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 23.11. Nice work everyone, thanks! Enhancement not pushed to 23.05.x |