Summary: | 'Save' and 'close' buttons confusing on multi-receive | ||
---|---|---|---|
Product: | Koha | Reporter: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Component: | Acquisitions | Assignee: | Bugs List <koha-bugs> |
Status: | NEW --- | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | agustinmoyano, jonathan.druart, kyle, martin.renvoize, michaela.sieber, nick, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Bug Depends on: | 8179 | ||
Bug Blocks: |
Description
Tomás Cohen Arazi (tcohen)
2023-05-26 13:46:38 UTC
Close is not saving, simply closing the modal. Saving is effectively saving the change you made in the modal. At least it is their intended behaviours. From what I found in the code, save mostly just closes the window. All of the inputs on the form have events attached - when the value is changed we update the row in the background In my understanding we effectively save the data stored in the "row" data of #order_edit when we click "Save": see onclick event on .modal-save which is calling save_rows When the modal opens, a copy of the underlying row is stored in the 'row' data element of the #order_edit element which is the modal itself. That data element is kept in sync with the events you mention, Nick. Not the 'real row' on the underlying table. And the 'real row' is synced using the `save_rows_()` function, looping through the 'real rows'. Nick: are you suggesting a more subtle issue? Like the row being stored as a reference to the one in the modal and causing issues? I meant `keep_row()` not `save_rows()`. Talking about the buttons: I feel like it might be more intuitive to have previous and next buttons next to each other on the left. I want to skip back and forth and now I have to 'move' over the other buttons each time. |