Summary: | Add checkout date and renewal date to display list of checked out items | ||
---|---|---|---|
Product: | Koha | Reporter: | Chris Cormack <chris> |
Component: | Circulation | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | cookie.wolfrom, koha.sekjal, nengard, paul.poulain |
Version: | 3.6 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Proposed fix
[SIGNED-OFF] Fix for Bug 3385 - Add checkout date and renewal date to display list of checked out items Revised fix Bug 3385 - Add checkout date and renewal date to display list of checked out items |
Description
Chris Cormack
2010-05-21 01:09:53 UTC
The checkout date is shown on the details and checkouts tabs in circulation and on the item details (Last borrowed) page. As far as I can tell the last renewal date is shown nowhere. My library asked about the renewal date, because a patron was claiming that one item has been renewed after he had placed a hold on it. It turned out everything was ok, but there was no way to get the information from the staff interface. Last renewal date would be a nice addition to the item details page. Created attachment 5879 [details] [review] Proposed fix Fix for Bug 3385 - Add checkout date and renewal date to display list of checked out items This patch doesn't fix the origial request to add the renewal date to the list of checked out items, but follows the other bug commenter's suggestion that the information be added to the item details page (moredetail.pl). The other part of this request, to add the checkout date, has already been fixed by another patch. Created attachment 5890 [details] [review] [SIGNED-OFF] Fix for Bug 3385 - Add checkout date and renewal date to display list of checked out items This patch doesn't fix the origial request to add the renewal date to the list of checked out items, but follows the other bug commenter's suggestion that the information be added to the item details page (moredetail.pl). The other part of this request, to add the checkout date, has already been fixed by another patch. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Simple enough Template only change (with corresponding perl code export of required param). Adds new strings, however, so may need to wait. Marking Passed QA Sorry guys, failed QA, dates are not formatted. My screen shows : Last renewed 2011-10-03, Due back on 12/05/2011 The 2nd date is OK, the renewed one is not formatted. Created attachment 6344 [details] [review] Revised fix Created attachment 6549 [details] [review] Bug 3385 - Add checkout date and renewal date to display list of checked out items This patch doesn't fix the origial request to add the renewal date to the list of checked out items, but follows the other bug commenter's suggestion that the information be added to the item details page (moredetail.pl). The other part of this request, to add the checkout date, has already been fixed by another patch. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> QA comment: the following construct: + $item->{$_} = format_date( $item->{$_} ) foreach qw/datelastborrowed dateaccessioned datelastseen lastreneweddate/; is not PBP friendly. It's recommended to write foreach { bla } perlcritic says it's a level 2 severity: Postfix control "foreach" used at line 131, column 69. See page 96 of PBP. (Severity: 2) We want to be level 5, so passed QA Patch pushed, please test |