| Summary: | Date for pending offline circulation is unformatted | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
| Component: | Circulation | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | RESOLVED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
| Severity: | trivial | ||
| Priority: | P5 - low | CC: | cecile.lambour, gmcharlt, jonathan.druart, kyle.m.hall |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
23.11.00,23.05.02,22.11.08
|
|
| Circulation function: | |||
| Attachments: |
Bug 33858: Format dates in offline circ
Bug 33858: Format dates in offline circ Bug 33858: Format dates in offline circ Bug 33858: Format dates in offline circ |
||
|
Description
Katrin Fischer
2023-05-29 17:41:03 UTC
Created attachment 152079 [details] [review] Bug 33858: Format dates in offline circ Should be as simple as that, but I have not tested the patch. Created attachment 152225 [details] [review] Bug 33858: Format dates in offline circ 1 - check item 3999900000001 out to a patron 2 - upload the attached KOC file from bug 33838 3 - navigate to pending offline circ actions 4 - verify that the date is shown unformatted 5 - apply patch 6 - verify that the date is now shown formatted Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> It works, but I updated it to use with_hours=1 to show the time, but we are still losing the second. Should we worry about that? Created attachment 152893 [details] [review] Bug 33858: Format dates in offline circ 1 - check item 3999900000001 out to a patron 2 - upload the attached KOC file from bug 33838 3 - navigate to pending offline circ actions 4 - verify that the date is shown unformatted 5 - apply patch 6 - verify that the date is now shown formatted Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Univ Brest <cecile.lambour@univ-brest.fr> Hi Cecile, is it a problem for you that the seconds part of the timestamp is missing or would that be ok? Hi Katrin, I don't use the feature. Created attachment 153156 [details] [review] Bug 33858: Format dates in offline circ 1 - check item 3999900000001 out to a patron 2 - upload the attached KOC file from bug 33838 3 - navigate to pending offline circ actions 4 - verify that the date is shown unformatted 5 - apply patch 6 - verify that the date is now shown formatted Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Univ Brest <cecile.lambour@univ-brest.fr> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Pushed to master for 23.11. Nice work everyone, thanks! Thanks for all the hard work! Pushed to 23.05.x for the next release Nice work everyone! Pushed to oldstable for 22.11.x |