Bug 33875

Summary: Missing closing tag a in API key management page
Product: Koha Reporter: Fridolin Somers <fridolin.somers>
Component: PatronsAssignee: Fridolin Somers <fridolin.somers>
Status: RESOLVED FIXED QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low CC: dcook, gmcharlt, kyle.m.hall
Version: Main   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33883
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.01,22.11.07
Circulation function:
Bug Depends on: 20568    
Bug Blocks: 33883    
Attachments: Bug 33875: Fix missing closing tag a in API key management page
Screenshot with patch
Bug 33875: Fix missing closing tag a in API key management page
Bug 33875: Fix missing closing tag a in API key management page

Description Fridolin Somers 2023-05-31 20:48:17 UTC
In API key management page, anchor closing tag is missing in :

<div class="dialog message">No keys defined for the current patron. <a href="#" class="toggle_element" data-element="#add-api-key" id="show-api-form"><i class="fa fa-plus"></i> Generate a new client id/secret pair</div>
Comment 1 Fridolin Somers 2023-05-31 21:04:04 UTC
Created attachment 151888 [details] [review]
Bug 33875: Fix missing closing tag a in API key management page

In API key management page, anchor closing tag is missing in message "No keys defined for the current patron".

This patch fixes that.
Also changes display with link on a new line.
Translatable text is on purpose surrounded by span or div.

Test plan :
1) Enable system preference  RESTOAuth2ClientCredentials
2) Go to a patron page
3) Click More > Manage API Keys
4) Look at page source HTML code
=> Check code is OK
Comment 2 Fridolin Somers 2023-05-31 21:05:57 UTC
Created attachment 151889 [details]
Screenshot with patch

I choose to propose a minor change in display to move link on a new line.
This looks better I think.
Also each translatable text is surrounded by span or div to ease translation.
Comment 3 Sam Lau 2023-06-01 16:58:14 UTC
Created attachment 151950 [details] [review]
Bug 33875: Fix missing closing tag a in API key management page

In API key management page, anchor closing tag is missing in message "No keys defined for the current patron".

This patch fixes that.
Also changes display with link on a new line.
Translatable text is on purpose surrounded by span or div.

Test plan :
1) Enable system preference  RESTOAuth2ClientCredentials
2) Go to a patron page
3) Click More > Manage API Keys
4) Look at page source HTML code
=> Check code is OK

Signed-off-by: Sam Lau <samalau@gmail.com>
Comment 4 David Cook 2023-06-02 01:25:08 UTC
Created attachment 151956 [details] [review]
Bug 33875: Fix missing closing tag a in API key management page

In API key management page, anchor closing tag is missing in message "No keys defined for the current patron".

This patch fixes that.
Also changes display with link on a new line.
Translatable text is on purpose surrounded by span or div.

Test plan :
1) Enable system preference  RESTOAuth2ClientCredentials
2) Go to a patron page
3) Click More > Manage API Keys
4) Look at page source HTML code
=> Check code is OK

Signed-off-by: Sam Lau <samalau@gmail.com>
Signed-off-by: David Cook <dcook@prosentient.com.au>
Comment 5 Tomás Cohen Arazi 2023-06-05 17:37:27 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 6 Matt Blenkinsop 2023-06-12 10:15:22 UTC
Nice work everyone!

Pushed to oldstable for 22.11.x