| Summary: | item-note-nonpublic and item-note-public are difficult to customize in the checkout table | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Lucas Gass (lukeg) <lucas> |
| Component: | Circulation | Assignee: | Lucas Gass (lukeg) <lucas> |
| Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, kyle.m.hall |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
23.11.00,23.05.04,22.11.11
|
|
| Circulation function: | |||
| Attachments: |
Bug 33876: Add class for styling
Bug 33876: Add class for styling Bug 33876: Add class for styling Bug 33876: Add class for styling |
||
|
Description
Lucas Gass (lukeg)
2023-05-31 22:30:08 UTC
Created attachment 151891 [details] [review] Bug 33876: Add class for styling To test: 1. Checkout and item that has a public and nonpublic note. 2. In the checkout table ( Title column ) notice the notes display. If you use the browser dev tools to inspect you'll notice a "-" outside of any HTML element. 3. Apply patch. 4. See the '-' is now inside of a html element with class of seperator. Created attachment 151949 [details] [review] Bug 33876: Add class for styling To test: 1. Checkout and item that has a public and nonpublic note. 2. In the checkout table ( Title column ) notice the notes display. If you use the browser dev tools to inspect you'll notice a "-" outside of any HTML element. 3. Apply patch. 4. See the '-' is now inside of a html element with class of seperator. Signed-off-by: Sam Lau <samalau@gmail.com> Hi Lucas, all for this change, but some small notes: * One of the new classes is "seperator", there is a small typo there, as it should be "separator", but that would make it collide with the class in the XSLT and cause some unintended side-effects. Maybe something not used yet? Created attachment 152326 [details] [review] Bug 33876: Add class for styling To test: 1. Checkout and item that has a public and nonpublic note. 2. In the checkout table ( Title column ) notice the notes display. If you use the browser dev tools to inspect you'll notice a "-" outside of any HTML element. 3. Apply patch. 4. See the '-' is now inside of a html element with class of seperator. Signed-off-by: Sam Lau <samalau@gmail.com> > * One of the new classes is "seperator", there is a small typo there, as it
> should be "separator", but that would make it collide with the class in the
> XSLT and cause some unintended side-effects. Maybe something not used yet?
Changed it to 'divider-dash'. Keeping Sam's sign-off line.
Created attachment 155381 [details] [review] Bug 33876: Add class for styling To test: 1. Checkout and item that has a public and nonpublic note. 2. In the checkout table ( Title column ) notice the notes display. If you use the browser dev tools to inspect you'll notice a "-" outside of any HTML element. 3. Apply patch. 4. See the '-' is now inside of a html element with class of seperator. Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed to master for 23.11. Nice work everyone, thanks! Nice small enhancement, I choose to backport Pushed to 23.05.x for 23.05.04 Nice work everyone! Pushed to oldstable for 22.11.x |