| Summary: | "Make sure to copy your API secret" message overlaps text | ||
|---|---|---|---|
| Product: | Koha | Reporter: | David Cook <dcook> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | RESOLVED FIXED | QA Contact: | David Cook <dcook> |
| Severity: | minor | ||
| Priority: | P5 - low | ||
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33875 | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
23.11.00,23.05.01,22.11.07
|
|
| Circulation function: | |||
| Bug Depends on: | 33875 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 33883: "Make sure to copy your API secret" message overlaps text
Bug 33883: "Make sure to copy your API secret" message overlaps text Bug 33883: "Make sure to copy your API secret" message overlaps text Bug 33883: "Make sure to copy your API secret" message overlaps text |
||
|
Description
David Cook
2023-06-02 01:22:14 UTC
Created attachment 151982 [details] [review] Bug 33883: "Make sure to copy your API secret" message overlaps text This patch updates the markup on the patron API keys page so that it uses standard classes for dialogs and page sections. To test you must have RESTOAuth2ClientCredentials enabled. - Apply the patch and locate a patron record. - From their checkout or detail page, choose More -> Manage API keys - Click "Generate a new client id/secret pair" - Enter a description and click Save. - You should see a message in a standard message-style dialog, "Make sure to copy your API secret now. You won’t be able to see it again!" - The API key information should be displayed in a .page-section div. - The table of existing keys should be displayed in a .page-section div. Created attachment 151983 [details] [review] Bug 33883: "Make sure to copy your API secret" message overlaps text This patch updates the markup on the patron API keys page so that it uses standard classes for dialogs and page sections. To test you must have RESTOAuth2ClientCredentials enabled. - Apply the patch and locate a patron record. - From their checkout or detail page, choose More -> Manage API keys - Click "Generate a new client id/secret pair" - Enter a description and click Save. - You should see a message in a standard message-style dialog, "Make sure to copy your API secret now. You won’t be able to see it again!" - The API key information should be displayed in a .page-section div. - The table of existing keys should be displayed in a .page-section div. Created attachment 151985 [details] [review] Bug 33883: "Make sure to copy your API secret" message overlaps text This patch updates the markup on the patron API keys page so that it uses standard classes for dialogs and page sections. To test you must have RESTOAuth2ClientCredentials enabled. - Apply the patch and locate a patron record. - From their checkout or detail page, choose More -> Manage API keys - Click "Generate a new client id/secret pair" - Enter a description and click Save. - You should see a message in a standard message-style dialog, "Make sure to copy your API secret now. You won’t be able to see it again!" - The API key information should be displayed in a .page-section div. - The table of existing keys should be displayed in a .page-section div. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Created attachment 152033 [details] [review] Bug 33883: "Make sure to copy your API secret" message overlaps text This patch updates the markup on the patron API keys page so that it uses standard classes for dialogs and page sections. To test you must have RESTOAuth2ClientCredentials enabled. - Apply the patch and locate a patron record. - From their checkout or detail page, choose More -> Manage API keys - Click "Generate a new client id/secret pair" - Enter a description and click Save. - You should see a message in a standard message-style dialog, "Make sure to copy your API secret now. You won’t be able to see it again!" - The API key information should be displayed in a .page-section div. - The table of existing keys should be displayed in a .page-section div. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: David Cook <dcook@prosentient.com.au> Pushed to master for 23.11. Nice work everyone, thanks! Pushed to master for 23.05. Nice work everyone, thanks! Nice work everyone! Pushed to oldstable for 22.11.x |