Bug 33892

Summary: Use template wrapper for tabs: OPAC authority detail
Product: Koha Reporter: Owen Leonard <oleonard>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low CC: matt.blenkinsop, testopia
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: Small patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.01,22.11.07
Circulation function:
Bug Depends on: 33891    
Bug Blocks: 32571    
Attachments: Bug 33892: Use template wrapper for tabs: OPAC authority detail
Bug 33892: Use template wrapper for tabs: OPAC authority detail
Bug 33892: Use template wrapper for tabs: OPAC authority detail

Description Owen Leonard 2023-06-05 12:57:11 UTC
Continuing the work of Bug 32571, I would like to update the OPAC authority detail page use the new WRAPPER for tabs
Comment 1 Owen Leonard 2023-06-05 14:34:19 UTC
Created attachment 151992 [details] [review]
Bug 33892: Use template wrapper for tabs: OPAC authority detail

This patch updates the OPAC authority detail page so that it uses
the new WRAPPER syntax to generate tabs markup.

To test, apply the patch and locate an authority record in the OPAC
which has notes fields.

When viewing the details for that record the notes should appear in a
single "Notes" tab.
Comment 2 Sam Lau 2023-06-05 15:00:32 UTC
Created attachment 151998 [details] [review]
Bug 33892: Use template wrapper for tabs: OPAC authority detail

This patch updates the OPAC authority detail page so that it uses
the new WRAPPER syntax to generate tabs markup.

To test, apply the patch and locate an authority record in the OPAC
which has notes fields.

When viewing the details for that record the notes should appear in a
single "Notes" tab.

Signed-off-by: Sam Lau <samalau@gmail.com>
Comment 3 Lucas Gass (lukeg) 2023-06-06 15:22:09 UTC
Created attachment 152049 [details] [review]
Bug 33892: Use template wrapper for tabs: OPAC authority detail

This patch updates the OPAC authority detail page so that it uses
the new WRAPPER syntax to generate tabs markup.

To test, apply the patch and locate an authority record in the OPAC
which has notes fields.

When viewing the details for that record the notes should appear in a
single "Notes" tab.

Signed-off-by: Sam Lau <samalau@gmail.com>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 4 Tomás Cohen Arazi (tcohen) 2023-06-06 18:40:02 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 5 Matt Blenkinsop 2023-06-12 11:43:07 UTC
Nice work everyone!

Pushed to oldstable for 22.11.x