Bug 33893

Created attachment 151995 [details] [review]
Bug 33893: Use template wrapper for tabs: OPAC checkout history

This patch updates the OPAC checkout history page so that it uses
the new WRAPPER syntax to generate tabs markup.

To test, apply the patch and make sure the OnSiteCheckouts system
preference is set to "disabled."

- Log into the OPAC as a patron with checkouts.
- View the checkout history page. The checkout history information
  should be displayed without any tabs.
- Enable the OnSiteCheckouts system preference and if necessary check
  out some on-site checkouts to your patron.
- On the OPAC history page there should now be three tabs: All,
  Checkouts, and On-site checokuts.
  - Switching between the tabs should filter the table accordingly.

The aria-controls attribute's point to all_checkouts_panel, checkout_panel, onsite_checkout_panel but I don't see those elements on the page.

(In reply to Lucas Gass from comment #2)
> The aria-controls attribute's point to all_checkouts_panel, checkout_panel,
> onsite_checkout_panel but I don't see those elements on the page.

I'm not sure how to resolve this one... There aren't actually three panels, so with the way the WRAPPER works at the moment we can either have uniquely-named tabs ("#all_checkouts-tab," "#checkout-tab," "onsite_checkout-tab") and invalid aria-controls, or duplicate tab IDs and aria-controls attributes that all point to the same (existing) tab.

I guess the accessibility-compliant option would be better?

> I guess the accessibility-compliant option would be better?

Is having duplicate ID's but correct aria-controls the accessibility-compliant option?

I would assume so. My assumption is that the rule against duplicate ID is more about semantics and DOM validity and less about making things work well with assistive technology. But that is just an assumption.

(In reply to Owen Leonard from comment #5)
> I would assume so. My assumption is that the rule against duplicate ID is
> more about semantics and DOM validity and less about making things work well
> with assistive technology. But that is just an assumption.

I'd have that assumption as well. I did find this:

https://accessibilityinsights.io/info-examples/web/duplicate-id/

So duplicate ID's are not great for accessibility but if the aria-controls are correct assistive technologies should behave as expected?

Created attachment 152912 [details] [review]
Bug 33893: Use template wrapper for tabs: OPAC checkout history

This patch updates the OPAC checkout history page so that it uses
the new WRAPPER syntax to generate tabs markup.

This patch also updates tab WRAPPER directives in html_helpers.inc to
allow us to pass a custom id for tab links in situations like this one
where we have multiple tabs requiring unique IDs but they all point to
the same panel.

To test, apply the patch and make sure the OnSiteCheckouts system
preference is set to "disabled."

- Log into the OPAC as a patron with checkouts.
- View the checkout history page. The checkout history information
  should be displayed without any tabs.
- Enable the OnSiteCheckouts system preference and if necessary check
  out some on-site checkouts to your patron.
- On the OPAC history page there should now be three tabs: All,
  Checkouts, and On-site checokuts.
  - Switching between the tabs should filter the table accordingly.
- Test that the changes to the tab wrapper have not broken tabs on other
  pages, e.g. bibliographic details or user summary.

Created attachment 153178 [details] [review]
Bug 33893: Use template wrapper for tabs: OPAC checkout history

This patch updates the OPAC checkout history page so that it uses
the new WRAPPER syntax to generate tabs markup.

This patch also updates tab WRAPPER directives in html_helpers.inc to
allow us to pass a custom id for tab links in situations like this one
where we have multiple tabs requiring unique IDs but they all point to
the same panel.

To test, apply the patch and make sure the OnSiteCheckouts system
preference is set to "disabled."

- Log into the OPAC as a patron with checkouts.
- View the checkout history page. The checkout history information
  should be displayed without any tabs.
- Enable the OnSiteCheckouts system preference and if necessary check
  out some on-site checkouts to your patron.
- On the OPAC history page there should now be three tabs: All,
  Checkouts, and On-site checokuts.
  - Switching between the tabs should filter the table accordingly.
- Test that the changes to the tab wrapper have not broken tabs on other
  pages, e.g. bibliographic details or user summary.

Signed-off-by: AlexanderBlanchardAC <alexander.blanchard@ptfs-europe.com>

Welcome, Alexander :)

Created attachment 153224 [details] [review]
Bug 33893: Use template wrapper for tabs: OPAC checkout history

This patch updates the OPAC checkout history page so that it uses
the new WRAPPER syntax to generate tabs markup.

This patch also updates tab WRAPPER directives in html_helpers.inc to
allow us to pass a custom id for tab links in situations like this one
where we have multiple tabs requiring unique IDs but they all point to
the same panel.

To test, apply the patch and make sure the OnSiteCheckouts system
preference is set to "disabled."

- Log into the OPAC as a patron with checkouts.
- View the checkout history page. The checkout history information
  should be displayed without any tabs.
- Enable the OnSiteCheckouts system preference and if necessary check
  out some on-site checkouts to your patron.
- On the OPAC history page there should now be three tabs: All,
  Checkouts, and On-site checokuts.
  - Switching between the tabs should filter the table accordingly.
- Test that the changes to the tab wrapper have not broken tabs on other
  pages, e.g. bibliographic details or user summary.

Signed-off-by: AlexanderBlanchardAC <alexander.blanchard@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Pushed to master for 23.11.

Nice work everyone, thanks!

Thanks for all the hard work!

Pushed to 23.05.x for the next release

Nice work everyone!

Pushed to oldstable for 22.11.x