| Summary: | Catalog search from the masthead searchbar produces a warning in the logs | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Matt Blenkinsop <matt.blenkinsop> |
| Component: | Searching | Assignee: | Matt Blenkinsop <matt.blenkinsop> |
| Status: | RESOLVED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
| Severity: | trivial | ||
| Priority: | P5 - low | ||
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
23.11.00,23.05.02,22.11.08
|
|
| Circulation function: | |||
| Attachments: |
Bug 33896: Check whether index is defined before string match
Bug 33896: Check whether index is defined before string match Bug 33896: Check whether index is defined before string match |
||
|
Description
Matt Blenkinsop
2023-06-05 13:45:40 UTC
Created attachment 151990 [details] [review] Bug 33896: Check whether index is defined before string match This patch checks that $indexes[$i] is defined before testing whether the string matches to remove the logged warning when searching Test plan: 1) In the intranet, search the catalog from the top search bar 2) Check plack-intranet-error.log 3) There should be a warning "[WARN] Use of uninitialized value within @indexes in string eq" 4) Apply patch 5) restart_all and then re-try the search 6) The warning should no longer appear Created attachment 152030 [details] [review] Bug 33896: Check whether index is defined before string match This patch checks that $indexes[$i] is defined before testing whether the string matches to remove the logged warning when searching Test plan: 1) In the intranet, search the catalog from the top search bar 2) Check plack-intranet-error.log 3) There should be a warning "[WARN] Use of uninitialized value within @indexes in string eq" 4) Apply patch 5) restart_all and then re-try the search 6) The warning should no longer appear Signed-off-by: David Cook <dcook@prosentient.com.au> Created attachment 152588 [details] [review] Bug 33896: Check whether index is defined before string match This patch checks that $indexes[$i] is defined before testing whether the string matches to remove the logged warning when searching Test plan: 1) In the intranet, search the catalog from the top search bar 2) Check plack-intranet-error.log 3) There should be a warning "[WARN] Use of uninitialized value within @indexes in string eq" 4) Apply patch 5) restart_all and then re-try the search 6) The warning should no longer appear Signed-off-by: David Cook <dcook@prosentient.com.au> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Thank you, Matt :) Pushed to master for 23.11. Nice work everyone, thanks! Thanks for all the hard work! Pushed to 23.05.x for the next release Nice work everyone! Pushed to 22.11.x for next release |