| Summary: | On opac-detail.tt the libraryInfoModal is outside of HTML tags | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Lucas Gass (lukeg) <lucas> |
| Component: | OPAC | Assignee: | Lucas Gass (lukeg) <lucas> |
| Status: | RESOLVED FIXED | QA Contact: | David Cook <dcook> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | david, dcook, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: |
This moves the HTML for the pop-up window with the information for a library (where it exists) on the OPAC detail page inside the <html> tag so that it validates correctly. There is no change to the appearance or behavior of the page.
|
Version(s) released in: |
23.11.00,23.05.01,22.11.07
|
| Circulation function: | |||
| Attachments: |
Bug 33902: Move modal inside HTML body
Bug 33902: Move modal inside HTML body Bug 33902: Move modal inside HTML body |
||
|
Description
Lucas Gass (lukeg)
2023-06-05 22:49:45 UTC
Created attachment 152017 [details] [review] Bug 33902: Move modal inside HTML body To test: -Go Administration > Libraries and add a URL for a branch. -Also add some OPAC info: ( via HTML Customizations ) -Now find a record belonging to that branch and bring up the OPAC detail page. -In the holdings table there should be a link under the 'Current library' column. -Clicking it should bring up a modal. -Make sure the modal pops up correctly, can be dismissed, and the 'Visit web site' link works. Nothing about the appearance or behavior of the page should change. Created attachment 152022 [details] [review] Bug 33902: Move modal inside HTML body To test: -Go Administration > Libraries and add a URL for a branch. -Also add some OPAC info: ( via HTML Customizations ) -Now find a record belonging to that branch and bring up the OPAC detail page. -In the holdings table there should be a link under the 'Current library' column. -Clicking it should bring up a modal. -Make sure the modal pops up correctly, can be dismissed, and the 'Visit web site' link works. Nothing about the appearance or behavior of the page should change. Signed-off-by: David Nind <david@davidnind.com> Created attachment 152031 [details] [review] Bug 33902: Move modal inside HTML body To test: -Go Administration > Libraries and add a URL for a branch. -Also add some OPAC info: ( via HTML Customizations ) -Now find a record belonging to that branch and bring up the OPAC detail page. -In the holdings table there should be a link under the 'Current library' column. -Clicking it should bring up a modal. -Make sure the modal pops up correctly, can be dismissed, and the 'Visit web site' link works. Nothing about the appearance or behavior of the page should change. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: David Cook <dcook@prosentient.com.au> The dependency is not PQA. Can someone check? (In reply to Tomás Cohen Arazi from comment #4) > The dependency is not PQA. Can someone check? I am removing the dependency. Neither of these patch sets conflict with one another. Pushed to master for 23.11. Nice work everyone, thanks! Pushed to master for 23.05. Nice work everyone, thanks! Nice work everyone! Pushed to oldstable for 22.11.x |