Created attachment 152116 [details] [review] Bug 33913: Improve translation of title tags: Circulation, holds, and ILL This patch updates circulation, holds, and ILL templates so that title tags can be more easily translated. To test, apply the patch and confirm that the following pages have the correct title tags: - Circulation -> Article requests - Catalog -> Bibliographic record -> Items -> View item's checkout history - Circulation -> Overdues with fines - Circulation -> Transfers - Circulation -> Checkout notes - Circulation -> Circulation home - Circulation -> Check out - Circulation -> Batch checkouts - Circulation -> Curbside pickups - Circulation -> On-site checkouts - Circulation -> Overdues - Circulation -> Holds to pull - Circulation -> Checkout to patron -> Print slip - Circulation -> Renew - Catalog -> Bibliographic record -> Request article - Circulation -> Hold ratios - Circulation -> Check in - Circulation -> Set library - Circulation -> Transfers to receive - Circulation -> Transfers to send - Circulation -> Holds queue - Circulation -> Holds awaiting pickup - ILL requests - Catalog -> Bibliographic record -> Holds https://bugs.koha-community.org/show_bug.cgi?id=33907 Created attachment 152117 [details] [review] Bug 33913: Improve translation of title tags: Circulation, holds, and ILL This patch updates circulation, holds, and ILL templates so that title tags can be more easily translated. To test, apply the patch and confirm that the following pages have the correct title tags: - Circulation -> Article requests - Catalog -> Bibliographic record -> Items -> View item's checkout history - Circulation -> Overdues with fines - Circulation -> Transfers - Circulation -> Checkout notes - Circulation -> Circulation home - Circulation -> Check out - Circulation -> Batch checkouts - Circulation -> Curbside pickups - Circulation -> On-site checkouts - Circulation -> Overdues - Circulation -> Holds to pull - Circulation -> Checkout to patron -> Print slip - Circulation -> Renew - Catalog -> Bibliographic record -> Request article - Circulation -> Hold ratios - Circulation -> Check in - Circulation -> Set library - Circulation -> Transfers to receive - Circulation -> Transfers to send - Circulation -> Holds queue - Circulation -> Holds awaiting pickup - ILL requests - Catalog -> Bibliographic record -> Holds Created attachment 152305 [details] [review] Bug 33913: Improve translation of title tags: Circulation, holds, and ILL This patch updates circulation, holds, and ILL templates so that title tags can be more easily translated. To test, apply the patch and confirm that the following pages have the correct title tags: - Circulation -> Article requests - Catalog -> Bibliographic record -> Items -> View item's checkout history - Circulation -> Overdues with fines - Circulation -> Transfers - Circulation -> Checkout notes - Circulation -> Circulation home - Circulation -> Check out - Circulation -> Batch checkouts - Circulation -> Curbside pickups - Circulation -> On-site checkouts - Circulation -> Overdues - Circulation -> Holds to pull - Circulation -> Checkout to patron -> Print slip - Circulation -> Renew - Catalog -> Bibliographic record -> Request article - Circulation -> Hold ratios - Circulation -> Check in - Circulation -> Set library - Circulation -> Transfers to receive - Circulation -> Transfers to send - Circulation -> Holds queue - Circulation -> Holds awaiting pickup - ILL requests - Catalog -> Bibliographic record -> Holds Created attachment 154670 [details] [review] Bug 33913: Improve translation of title tags: Circulation, holds, and ILL This patch updates circulation, holds, and ILL templates so that title tags can be more easily translated. To test, apply the patch and confirm that the following pages have the correct title tags: - Circulation -> Article requests - Catalog -> Bibliographic record -> Items -> View item's checkout history - Circulation -> Overdues with fines - Circulation -> Transfers - Circulation -> Checkout notes - Circulation -> Circulation home - Circulation -> Check out - Circulation -> Batch checkouts - Circulation -> Curbside pickups - Circulation -> On-site checkouts - Circulation -> Overdues - Circulation -> Holds to pull - Circulation -> Checkout to patron -> Print slip - Circulation -> Renew - Catalog -> Bibliographic record -> Request article - Circulation -> Hold ratios - Circulation -> Check in - Circulation -> Set library - Circulation -> Transfers to receive - Circulation -> Transfers to send - Circulation -> Holds queue - Circulation -> Holds awaiting pickup - ILL requests - Catalog -> Bibliographic record -> Holds Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Overall this is a nice improvement, but there are a few where we lose context:
Now:
%s Batch check out to %s › %s Circulation › Koha␠
%1$s: IF patron
%2$s: INCLUDE 'patron-title.inc' invert_name = 1 no_html = 1
%3$s: END
The second %s can be moved if needed, the hints make it clear that it's a patron's name.
New:
Batch check out to
There will no longer be a clue, that this string is followed by a name and you will no longer be able to move the placeholder as it might be required for correct grammar.
There are a few more of these:
+ [% t("Checking out to") | html %] [% INCLUDE 'patron-title.inc' invert_name = 1 no_html = 1 %] ›
+ [% t("Batch check out to") | html %] [% INCLUDE 'patron-title.inc' invert_name = 1 no_html = 1 %] ›
+ [% t("Items overdue as of") | html %] [% todaysdate | $KohaDates %] ›
Also:
[% t("Place a hold on") | html %] [% INCLUDE 'biblio-title-head.inc' %] ›
Created attachment 154752 [details] [review] Bug 33913: Improve translation of title tags: Circulation, holds, and ILL This patch updates circulation, holds, and ILL templates so that title tags can be more easily translated. To test, apply the patch and confirm that the following pages have the correct title tags: - Circulation -> Article requests - Catalog -> Bibliographic record -> Items -> View item's checkout history - Circulation -> Overdues with fines - Circulation -> Transfers - Circulation -> Checkout notes - Circulation -> Circulation home - Circulation -> Check out - Circulation -> Batch checkouts - Circulation -> Curbside pickups - Circulation -> On-site checkouts - Circulation -> Overdues - Circulation -> Holds to pull - Circulation -> Checkout to patron -> Print slip - Circulation -> Renew - Catalog -> Bibliographic record -> Request article - Circulation -> Hold ratios - Circulation -> Check in - Circulation -> Set library - Circulation -> Transfers to receive - Circulation -> Transfers to send - Circulation -> Holds queue - Circulation -> Holds awaiting pickup - ILL requests - Catalog -> Bibliographic record -> Holds Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 154753 [details] [review] Bug 33913: (QA follow-up) Move variables into strings To test: 1) Checking out to {patron} * Search for any patron * Click on cardnumber in patron search results * Verify that page title reads correctly and includes patron's name 2) Batch check out to {patron} * Activate BatchCheckouts system preference * Check all patron categories for BatchCheckoutsValidCategories * Go to any patron account * Click on batch checkout tab * Verify that the page title reads correctly and includes patron's name 3) Place a hold on {title} * Search for a record with items in the staff interface catalog * Click on 'place holds' * Verify that the page title reads correctly and includes the title of the record 4) Overdues as of {date} * Set DateFormat system preference to any other than default * Go to circulation > overdues * Verify the page title includes today's date in the correct format Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Owen or Caroline - could you maybe double-check my last patch? Created attachment 154800 [details] [review] Bug 33913: (QA follow-up) Move variables into strings To test: 1) Checking out to {patron} * Search for any patron * Click on cardnumber in patron search results * Verify that page title reads correctly and includes patron's name 2) Batch check out to {patron} * Activate BatchCheckouts system preference * Check all patron categories for BatchCheckoutsValidCategories * Go to any patron account * Click on batch checkout tab * Verify that the page title reads correctly and includes patron's name 3) Place a hold on {title} * Search for a record with items in the staff interface catalog * Click on 'place holds' * Verify that the page title reads correctly and includes the title of the record 4) Overdues as of {date} * Set DateFormat system preference to any other than default * Go to circulation > overdues * Verify the page title includes today's date in the correct format Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Thx, Owen! Pushed to master for 23.11. Nice work everyone, thanks! I choose to not backport to stable to avoid too much translation work |
This patch will modify catalog, holds, and ILL templates in the staff client so that translatable strings in the <title> tag are wrapped in the correct translation function, e.g. [% t('Translate me') %]