Summary: | Improve translation of title tags: Labels | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | fridolin.somers, testopia |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
23.11.00
|
|
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 33906 | ||
Attachments: |
Bug 33916: Improve translation of title tags: Labels
Bug 33916: Improve translation of title tags: Labels Bug 33916: (QA follow-up) Remove redundant template code Bug 33916: Improve translation of title tags: Labels Bug 33916: (QA follow-up) Remove redundant template code Bug 33916: (QA follow-up) Correct "Label profiles" |
Description
Owen Leonard
2023-06-06 15:59:55 UTC
Created attachment 154689 [details] [review] Bug 33916: Improve translation of title tags: Labels This patch label creator templates so that title tags can be more easily translated. The patch also makes some minor changes to some templates to improve consistency between page title, breadcrumb navigation, and page heading. To test, apply the patch and confirm that the following pages have the correct title tags: - Cataloging -> Label creator home - Manage -> Label batches - Edit -> - Click the "Add item(s)" button without entering any barcodes or item numbers in the form. - Test the search form and search results - Manage -> Layouts - Manage -> Label templates - Manage -> Printer profiles - New -> Label batch - New -> Layout - New -> Label template - New -> Printer profile - New -> Barcode range - Cataloging -> Barcode image generator - Cataloging -> Quick spine label creator Created attachment 155556 [details] [review] Bug 33916: Improve translation of title tags: Labels This patch label creator templates so that title tags can be more easily translated. The patch also makes some minor changes to some templates to improve consistency between page title, breadcrumb navigation, and page heading. To test, apply the patch and confirm that the following pages have the correct title tags: - Cataloging -> Label creator home - Manage -> Label batches - Edit -> - Click the "Add item(s)" button without entering any barcodes or item numbers in the form. - Test the search form and search results - Manage -> Layouts - Manage -> Label templates - Manage -> Printer profiles - New -> Label batch - New -> Layout - New -> Label template - New -> Printer profile - New -> Barcode range - Cataloging -> Barcode image generator - Cataloging -> Quick spine label creator Signed-off-by: Salah Ghedda <salah.ghedda@inLibro.com> Couldn't this be simplified? + [% IF ( label_element == 'layout' ) %] + <h2>[% PROCESS translate_label_element element=label_element_title %]</h2> + [% ELSIF ( label_element == 'template' ) %] + <h2>[% PROCESS translate_label_element element=label_element_title %]</h2> + [% ELSIF ( label_element == 'profile' ) %] + <h2>[% PROCESS translate_label_element element=label_element_title %]</h2> + [% ELSIF ( label_element == 'batch' ) %] + <h2>[% PROCESS translate_label_element element=label_element_title %]</h2> + [% END %] To just be? <h2>[% PROCESS translate_label_element element=label_element_title %]</h2> If the outcome is always the same, why do the if/else? Created attachment 156731 [details] [review] Bug 33916: (QA follow-up) Remove redundant template code Created attachment 157569 [details] [review] Bug 33916: Improve translation of title tags: Labels This patch label creator templates so that title tags can be more easily translated. The patch also makes some minor changes to some templates to improve consistency between page title, breadcrumb navigation, and page heading. To test, apply the patch and confirm that the following pages have the correct title tags: - Cataloging -> Label creator home - Manage -> Label batches - Edit -> - Click the "Add item(s)" button without entering any barcodes or item numbers in the form. - Test the search form and search results - Manage -> Layouts - Manage -> Label templates - Manage -> Printer profiles - New -> Label batch - New -> Layout - New -> Label template - New -> Printer profile - New -> Barcode range - Cataloging -> Barcode image generator - Cataloging -> Quick spine label creator Signed-off-by: Salah Ghedda <salah.ghedda@inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 157570 [details] [review] Bug 33916: (QA follow-up) Remove redundant template code Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 157571 [details] [review] Bug 33916: (QA follow-up) Correct "Label profiles" ... to "Printer profiles" Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 23.11. Nice work everyone, thanks! Enhancement not pushed to 23.05.x |