Bug 33924

Summary: Improve translation of title tags: Rotating collections
Product: Koha Reporter: Owen Leonard <oleonard>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Lucas Gass (lukeg) <lucas>
Severity: enhancement    
Priority: P5 - low CC: fridolin.somers, lucas, testopia
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: Small patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
23.11.00
Circulation function:
Bug Depends on:    
Bug Blocks: 33906    
Attachments: Bug 33924: Improve translation of title tags: Rotating collections
Bug 33924: Improve translation of title tags: Rotating collections
Bug 33924: Improve translation of title tags: Rotating collections

Description Owen Leonard 2023-06-06 16:15:03 UTC
This patch will modify rotating collections templates in the staff client so that translatable strings in the <title> tag are wrapped in the correct translation function, e.g. [% t('Translate me') %]
Comment 1 Owen Leonard 2023-09-05 15:57:14 UTC
Created attachment 155226 [details] [review]
Bug 33924: Improve translation of title tags: Rotating collections

This patch updates rotating collection templates so that title tags can
be more easily translated.

The patch also makes some corrections to breadcrumb navigation and page
headers to make sure they are consistent with titles.

To test, apply the patch and confirm that the following rotating
collection pages have the correct title tags:

- Tools -> Rotating collections
  - Rotating collections list
  -> New collection
  -> Edit collection
  -> Delete collection -> Confirmation page
  -> Transfer collection
Comment 2 Salah Ghedda 2023-09-12 19:21:17 UTC
Created attachment 155571 [details] [review]
Bug 33924: Improve translation of title tags: Rotating collections

This patch updates rotating collection templates so that title tags can
be more easily translated.

The patch also makes some corrections to breadcrumb navigation and page
headers to make sure they are consistent with titles.

To test, apply the patch and confirm that the following rotating
collection pages have the correct title tags:

- Tools -> Rotating collections
  - Rotating collections list
  -> New collection
  -> Edit collection
  -> Delete collection -> Confirmation page
  -> Transfer collection

Signed-off-by: Salah Ghedda <salah.ghedda@inLibro.com>
Comment 3 Lucas Gass (lukeg) 2023-09-18 16:24:55 UTC
Created attachment 155850 [details] [review]
Bug 33924: Improve translation of title tags: Rotating collections

This patch updates rotating collection templates so that title tags can
be more easily translated.

The patch also makes some corrections to breadcrumb navigation and page
headers to make sure they are consistent with titles.

To test, apply the patch and confirm that the following rotating
collection pages have the correct title tags:

- Tools -> Rotating collections
  - Rotating collections list
  -> New collection
  -> Edit collection
  -> Delete collection -> Confirmation page
  -> Transfer collection

Signed-off-by: Salah Ghedda <salah.ghedda@inLibro.com>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 4 Tomás Cohen Arazi (tcohen) 2023-09-18 18:54:44 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 5 Fridolin Somers 2023-09-18 21:51:39 UTC
Enhancement not pushed to 23.05.x