| Summary: | Unnecessary processing in opac-readingrec if BakerTaylor and Syndetics off | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | RESOLVED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | nick |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
23.11.00,23.05.02,22.11.08
|
|
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 33746 | ||
| Attachments: |
Bug 33950: Don't get marcxml if not necessary - opac-readingrecord.pl
Bug 33950: Don't get marcxml if not necessary - opac-readingrecord.pl |
||
|
Description
Jonathan Druart
2023-06-08 08:14:17 UTC
Created attachment 152140 [details] [review] Bug 33950: Don't get marcxml if not necessary - opac-readingrecord.pl We are retrieving normalized_upc from the MARC XML in the controller (opac-readingrec.pl) for all issues to display, but this is only used if BakerTaylor or Syndetics are enabled. Test plan: Have some checkouts and confirm that the checkout history is displayed the same before and after this patch. You should also test BakerTaylor or Syndetics and see if they are working correctly, but I have no idea how to test them! Created attachment 152144 [details] [review] Bug 33950: Don't get marcxml if not necessary - opac-readingrecord.pl We are retrieving normalized_upc from the MARC XML in the controller (opac-readingrec.pl) for all issues to display, but this is only used if BakerTaylor or Syndetics are enabled. Test plan: Have some checkouts and confirm that the checkout history is displayed the same before and after this patch. You should also test BakerTaylor or Syndetics and see if they are working correctly, but I have no idea how to test them! Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Trivial and straightforward, passing QA Pushed to master for 23.11. Nice work everyone, thanks! Thanks for all the hard work! Pushed to 23.05.x for the next release Nice work everyone! Pushed to oldstable for 22.11.x |