| Summary: | Remove C4::BackgroundJob from process_koc | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | martin.renvoize |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
23.11.00
|
|
| Circulation function: | |||
| Bug Depends on: | 2608 | ||
| Bug Blocks: | 33963 | ||
| Attachments: |
Bug 33962: Remove background job from process koc
Bug 33962: Remove background job from process koc Bug 33962: Remove background job from process koc |
||
|
Description
Jonathan Druart
2023-06-08 15:35:47 UTC
Created attachment 152206 [details] [review] Bug 33962: Remove background job from process koc The last occurrence of C4::BackgroundJob is in process_koc.pl that is used to upload a file. Added by bug 2608 (15 years ago), I think it does not longer make sense as networks are faster, and we should not expect big koc files to be uploaded. If there are complains we will move it to Koha::BackgroundJob. Test plan: Upload a koc file, enqueue the operations and confirm that everything is working correctly Created attachment 152373 [details] [review] Bug 33962: Remove background job from process koc The last occurrence of C4::BackgroundJob is in process_koc.pl that is used to upload a file. Added by bug 2608 (15 years ago), I think it does not longer make sense as networks are faster, and we should not expect big koc files to be uploaded. If there are complains we will move it to Koha::BackgroundJob. Test plan: Upload a koc file, enqueue the operations and confirm that everything is working correctly Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Makes sense to me Created attachment 152376 [details] [review] Bug 33962: Remove background job from process koc The last occurrence of C4::BackgroundJob is in process_koc.pl that is used to upload a file. Added by bug 2608 (15 years ago), I think it does not longer make sense as networks are faster, and we should not expect big koc files to be uploaded. If there are complains we will move it to Koha::BackgroundJob. Test plan: Upload a koc file, enqueue the operations and confirm that everything is working correctly Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Pushed to master for 23.11. Nice work everyone, thanks! Leaving out of 23.05.x branch for now. |