Summary: | Deleting item record leaves a hole in patron's reading history | ||
---|---|---|---|
Product: | Koha | Reporter: | Mickey Coalwell <mcoalwell> |
Component: | Circulation | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | normal | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | chris, koha.sekjal, liz, magnus, mcoalwell, smoreland |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Hole in reading record example
Proposed fix Signed-off patch |
Description
Chris Cormack
2010-05-21 01:10:01 UTC
This bug still exists in master. The query which pulls information for the reading history: SELECT *, issues.timestamp as issuestimestamp, issues.renewals AS renewals,items.renewals AS totalrenewals,items.timestamp AS itemstimestamp FROM issues LEFT JOIN items on items.itemnumber=issues.itemnumber LEFT JOIN biblio ON items.biblionumber=biblio.biblionumber LEFT JOIN biblioitems ON items.biblioitemnumber=biblioitems.biblioitemnumber WHERE borrowernumber=? UNION ALL SELECT *, old_issues.timestamp as issuestimestamp, old_issues.renewals AS renewals,items.renewals AS totalrenewals,items.timestamp AS itemstimestamp FROM old_issues LEFT JOIN items on items.itemnumber=old_issues.itemnumber LEFT JOIN biblio ON items.biblionumber=biblio.biblionumber LEFT JOIN biblioitems ON items.biblioitemnumber=biblioitems.biblioitemnumber WHERE borrowernumber=? order by $order Add " AND old_issues.itemnumber IS NOT NULL" ? Created attachment 4164 [details] [review] Proposed fix Created attachment 4288 [details] [review] Signed-off patch Before applying the patch: Deleting an item leaves a hole in the reading history - as pictured in attachment 1278 [details]. After applying the patch: The deleted item is not displayed at all in the reading history, neither in the staff client nor in the "my summary" page of the user in question in the OPAC. This goes for both items that were deleted before and after the patch was applied. Signing off! As a patron, I would question any apparent 'holes' in my reading history. It doesn't matter to me that the Library weeded a book I read - I want a record of every item I read to remain. Is it possible to retain a brief title, similar to what appears in the Fines table? Simple SQL query change, easy to read, marking as Passed QA. A more robust solution for keeping reading history after an item is deleted is welcome, but this patch cures a graphic inconsistency in the current implementation. Pushed, please test http://ticket.bywatersolutions.com/show_bug.cgi?id=6421 Nicole suggested I comment on this bug. I see Sharon was in the loop for this development work last year, but it doesn't look her concerns were addressed in any way. I have the same concerns, and am wondering if this patch could become a Koha preference rather than a default setting. Here is a member library explaining the situation, and making a case for the previous behavior: **************************************************************************** I have a question about the circulation history. I thought it used to be if we deleted an item and then looked up the circ history of a patron who had previously checked said item out there would be an entry with dates but no title/barcode, etc. While it may not have been functionally perfect, we miss that feature. Lately we've noticed any items that are deleted in KOHA also are wiped clean from the circ history as if they've never checked it out. The little bit of info that used to be there was useful to us to see when an item (even without title/barcode, etc) was checked out, due, etc. just in case we had to fine the patron. There is not much useful info on fined items once they have been deleted. Would there be a possibility in a future upgrade or something of KOHA to keep the info in the circ history even after the item has been deleted? Also, patrons who accrued LOST ITEM fines in the past who used to have a line in their fine history of something we deleted (listing dates but no titles/links) no longer have that line included. Not good news in our opinion. ****************************************************************************** Thanks for your attention, Mickey Catalyst is working on filling in the reading record with titles from deleted items for Horowhenua District Council. That work is being followed on bug 8483, which I will add here as a "see also." Released in 3.10.0 |