Bug 33976

Summary:	Claims returned option is not disabled in moredetail.pl if the item has a different lost status
Product:	Koha	Reporter:	Emily Lamancusa (emlam) <emily.lamancusa>
Component:	Circulation	Assignee:	Emily Lamancusa (emlam) <emily.lamancusa>
Status:	RESOLVED FIXED	QA Contact:	Testopia <testopia>
Severity:	normal
Priority:	P5 - low	CC:	gmcharlt, kyle.m.hall, martin.renvoize
Version:	Main
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	Trivial patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:	23.11.00,23.05.02,22.11.08
Circulation function:
Attachments:	Bug 33976: Disable claims returned option in moredetail.pl when another lost status is selected Bug 33976: Disable claims returned option in moredetail.pl when another lost status is selected Bug 33976: Disable claims returned option in moredetail.pl when another lost status is selected

Description Emily Lamancusa (emlam) 2023-06-09 18:28:12 UTC

In Bug 24279, we disabled the "Claims Returned" option in the Lost status drop-down in moredetail.pl, because the claims returned feature does not work correctly if the status is set in that way.

However, if an item already has a different Lost status, the "Claims Returned" option is selectable, although it should not be.

Comment 1 Emily Lamancusa (emlam) 2023-06-09 19:02:26 UTC

Created attachment 152264 [details] [review]
Bug 33976: Disable claims returned option in moredetail.pl when another lost status is selected

Prevent "claims returned" from being selectable from moredetail.pl, even
if another lost status is already set

To test:
1. Configure Claims returned
    i. Go to Administration > Authorized Values > LOST
    ii. Add a new authorized value with value:6 and description:Claims returned
    iii. Go to Administration > System Preferences
    iv. Set ClaimReturnedLostValue to 6 and save
2. Go to any title record and click the barcode for any item
3. Click the Lost status drop-down.
   Note that the Claims Returned option is disabled.
4. Select a Lost status and click "Set status"
5. Click the Lost status drop-down.
   Note that the Claims Returned option is now selectable.
6. Apply the patch and refresh the page
7. Note that the Claims Returned option is now disabled.
8. Find a different item and check it out to a customer.
9. On that customer's account, click "Claim Returned" for that item
10. Click the barcode to view moredetail for that item
    Note that the Lost status drop-down is disabled with Claims Returned selected

Comment 2 Sam Lau 2023-06-14 15:49:15 UTC

Created attachment 152345 [details] [review]
Bug 33976: Disable claims returned option in moredetail.pl when another lost status is selected

Prevent "claims returned" from being selectable from moredetail.pl, even
if another lost status is already set

To test:
1. Configure Claims returned
    i. Go to Administration > Authorized Values > LOST
    ii. Add a new authorized value with value:6 and description:Claims returned
    iii. Go to Administration > System Preferences
    iv. Set ClaimReturnedLostValue to 6 and save
2. Go to any title record and click the barcode for any item
3. Click the Lost status drop-down.
   Note that the Claims Returned option is disabled.
4. Select a Lost status and click "Set status"
5. Click the Lost status drop-down.
   Note that the Claims Returned option is now selectable.
6. Apply the patch and refresh the page
7. Note that the Claims Returned option is now disabled.
8. Find a different item and check it out to a customer.
9. On that customer's account, click "Claim Returned" for that item
10. Click the barcode to view moredetail for that item
    Note that the Lost status drop-down is disabled with Claims Returned selected

Signed-off-by: Sam Lau <samalau@gmail.com>

Comment 3 Martin Renvoize (ashimema) 2023-06-26 12:09:50 UTC

Created attachment 152681 [details] [review]
Bug 33976: Disable claims returned option in moredetail.pl when another lost status is selected

Prevent "claims returned" from being selectable from moredetail.pl, even
if another lost status is already set

To test:
1. Configure Claims returned
    i. Go to Administration > Authorized Values > LOST
    ii. Add a new authorized value with value:6 and description:Claims returned
    iii. Go to Administration > System Preferences
    iv. Set ClaimReturnedLostValue to 6 and save
2. Go to any title record and click the barcode for any item
3. Click the Lost status drop-down.
   Note that the Claims Returned option is disabled.
4. Select a Lost status and click "Set status"
5. Click the Lost status drop-down.
   Note that the Claims Returned option is now selectable.
6. Apply the patch and refresh the page
7. Note that the Claims Returned option is now disabled.
8. Find a different item and check it out to a customer.
9. On that customer's account, click "Claim Returned" for that item
10. Click the barcode to view moredetail for that item
    Note that the Lost status drop-down is disabled with Claims Returned selected

Signed-off-by: Sam Lau <samalau@gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Comment 4 Martin Renvoize (ashimema) 2023-06-26 12:10:21 UTC

Working as expected and change makes logical sense.

Passing QA

Comment 5 Tomás Cohen Arazi (tcohen) 2023-06-26 14:41:22 UTC

Pushed to master for 23.11.

Nice work everyone, thanks!

Comment 6 Martin Renvoize (ashimema) 2023-07-17 14:41:23 UTC

Thanks for all the hard work!

Pushed to 23.05.x for the next release

Comment 7 Pedro Amorim 2023-07-18 11:54:51 UTC

Nice work everyone!

Pushed to 22.11.x for next release