| Summary: | Fix 'Recalls awaiting pickup' report if there are recalls waiting a problematic number of days | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Aleisha Amohia <aleisha> |
| Component: | Circulation | Assignee: | Aleisha Amohia <aleisha> |
| Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | gmcharlt, kyle.m.hall, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | Sponsored | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 19532 | ||
| Bug Blocks: | 33992 | ||
| Attachments: |
Bug 33990: Correctly access subtitle for Recalls awaiting pickup report
Bug 33990: Correctly access subtitle for Recalls awaiting pickup report Bug 33990: Correctly access subtitle for Recalls awaiting pickup report |
||
|
Description
Aleisha Amohia
2023-06-13 04:01:37 UTC
Created attachment 152286 [details] [review] Bug 33990: Correctly access subtitle for Recalls awaiting pickup report This patch fixes how the bibliographic record's subtitle is fetched to prevent the page from exploding when viewing the recalls awaiting pickup for a problematic number of days. To test: 1. Enable UseRecalls syspref and set the relevant circulation and fines rules to configure recalls 2. Set the RecallsMaxPickUpDelay to 1 day 3. Check out Item A to Patron A 4. Log into the OPAC as Patron B 5. Search for Item A and place a recall 6. Log back into the staff interface and check in Item A 7. Confirm the recall as waiting for Patron B 8. Go to Circulation -> Recalls awaiting pickup 9. Confirm your recall exists under the 'Recalls waiting' tab 10. Change the waiting_date in the database for this recall to a few days ago so we would expect to see it under the 'Recalls waiting over 1 days' tab sudo koha-mysql INSTANCE select * from recalls; # to get the recall_id update recalls set waiting_date = "2023-06-10 03:54:21" where recall_id = X; 11. Refresh the Circulation -> Recalls awaiting pickup page 12. Confirm the page blows up and there is an error 13. Apply the patch and refresh the page 14. Confirm the page loads successfully and your recall is showing as expected under the 'Recalls waiting over 1 days' tab 15. Confirm the subtitle (probably in 245$b) shows as expected Sponsored-by: Auckland University of Technology Created attachment 152311 [details] [review] Bug 33990: Correctly access subtitle for Recalls awaiting pickup report This patch fixes how the bibliographic record's subtitle is fetched to prevent the page from exploding when viewing the recalls awaiting pickup for a problematic number of days. To test: 1. Enable UseRecalls syspref and set the relevant circulation and fines rules to configure recalls 2. Set the RecallsMaxPickUpDelay to 1 day 3. Check out Item A to Patron A 4. Log into the OPAC as Patron B 5. Search for Item A and place a recall 6. Log back into the staff interface and check in Item A 7. Confirm the recall as waiting for Patron B 8. Go to Circulation -> Recalls awaiting pickup 9. Confirm your recall exists under the 'Recalls waiting' tab 10. Change the waiting_date in the database for this recall to a few days ago so we would expect to see it under the 'Recalls waiting over 1 days' tab sudo koha-mysql INSTANCE select * from recalls; # to get the recall_id update recalls set waiting_date = "2023-06-10 03:54:21" where recall_id = X; 11. Refresh the Circulation -> Recalls awaiting pickup page 12. Confirm the page blows up and there is an error 13. Apply the patch and refresh the page 14. Confirm the page loads successfully and your recall is showing as expected under the 'Recalls waiting over 1 days' tab 15. Confirm the subtitle (probably in 245$b) shows as expected Sponsored-by: Auckland University of Technology Signed-off-by: Sam Lau <samalau@gmail.com> Created attachment 152602 [details] [review] Bug 33990: Correctly access subtitle for Recalls awaiting pickup report This patch fixes how the bibliographic record's subtitle is fetched to prevent the page from exploding when viewing the recalls awaiting pickup for a problematic number of days. To test: 1. Enable UseRecalls syspref and set the relevant circulation and fines rules to configure recalls 2. Set the RecallsMaxPickUpDelay to 1 day 3. Check out Item A to Patron A 4. Log into the OPAC as Patron B 5. Search for Item A and place a recall 6. Log back into the staff interface and check in Item A 7. Confirm the recall as waiting for Patron B 8. Go to Circulation -> Recalls awaiting pickup 9. Confirm your recall exists under the 'Recalls waiting' tab 10. Change the waiting_date in the database for this recall to a few days ago so we would expect to see it under the 'Recalls waiting over 1 days' tab sudo koha-mysql INSTANCE select * from recalls; # to get the recall_id update recalls set waiting_date = "2023-06-10 03:54:21" where recall_id = X; 11. Refresh the Circulation -> Recalls awaiting pickup page 12. Confirm the page blows up and there is an error 13. Apply the patch and refresh the page 14. Confirm the page loads successfully and your recall is showing as expected under the 'Recalls waiting over 1 days' tab 15. Confirm the subtitle (probably in 245$b) shows as expected Sponsored-by: Auckland University of Technology Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Hi, I'm sorry but the last template refactorings we've made to the codebase have this not apply. Please rebase and I'll make sure it gets pushed with high priority. Thanks This patch is no longer needed, bug is fixed upstream |