| Summary: | Subscription details link on bibliographic detail page should have permission check | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | RESOLVED FIXED | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | martin.renvoize |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
23.11.00,23.05.02,22.11.08
|
|
| Circulation function: | |||
| Attachments: |
Bug 33999: Subscription details link on bibliographic detail page should have permission check
Bug 33999: Subscription details link on bibliographic detail page should have permission check Bug 33999: (follow-up) Use link-styled button Bug 33999: Subscription details link on bibliographic detail page should have permission check Bug 33999: (follow-up) Use link-styled button |
||
|
Description
Owen Leonard
2023-06-13 16:39:49 UTC
Created attachment 152314 [details] [review] Bug 33999: Subscription details link on bibliographic detail page should have permission check This patch wraps the "Subscription details" link on the bibliographic detail page with a permissions check, "CAN_user_serials," so that a user lacking permission to access the Serials module will not be shown the link. To test, apply the patch and view the bibliographic detail page of a serial record. - When viewing the "Subscriptions" tab as a user with Serials permissions you should see the "Subscription details" link. - When viewing the tab as a user without the correct permissions the link should not be present. Created attachment 152320 [details] [review] Bug 33999: Subscription details link on bibliographic detail page should have permission check This patch wraps the "Subscription details" link on the bibliographic detail page with a permissions check, "CAN_user_serials," so that a user lacking permission to access the Serials module will not be shown the link. To test, apply the patch and view the bibliographic detail page of a serial record. - When viewing the "Subscriptions" tab as a user with Serials permissions you should see the "Subscription details" link. - When viewing the tab as a user without the correct permissions the link should not be present. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> The permission check is correct of course, but I am not sure about turning this into a button. For me a button means "action", but here it's "navigation". Owen, what do you think? Created attachment 152687 [details] [review] Bug 33999: (follow-up) Use link-styled button Created attachment 152977 [details] [review] Bug 33999: Subscription details link on bibliographic detail page should have permission check This patch wraps the "Subscription details" link on the bibliographic detail page with a permissions check, "CAN_user_serials," so that a user lacking permission to access the Serials module will not be shown the link. To test, apply the patch and view the bibliographic detail page of a serial record. - When viewing the "Subscriptions" tab as a user with Serials permissions you should see the "Subscription details" link. - When viewing the tab as a user without the correct permissions the link should not be present. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 152978 [details] [review] Bug 33999: (follow-up) Use link-styled button Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Nice catch, Passing QA Pushed to master for 23.11. Nice work everyone, thanks! Thanks for all the hard work! Pushed to 23.05.x for the next release Nice work everyone! Pushed to oldstable for 22.11.x |