Bug 34002

Summary:	Check for stage_marc_import permission when adding to basket from a new file
Product:	Koha	Reporter:	Lucas Gass (lukeg) <lucas>
Component:	Acquisitions	Assignee:	Lucas Gass (lukeg) <lucas>
Status:	RESOLVED FIXED	QA Contact:	Katrin Fischer <katrin.fischer>
Severity:	normal
Priority:	P5 - low
Version:	Main
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	Trivial patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:	23.11.00,23.05.02,22.11.08
Circulation function:
Attachments:	Bug 34002: Check for stage_marc_import permssion Bug 34002: Check for stage_marc_import permssion Bug 34002: Check for stage_marc_import permssion

Description Lucas Gass (lukeg) 2023-06-13 19:40:51 UTC

To recreate:

-Log in to the staff client as a user who has  Acquisition management (acquisition) permissions but not the stage_marc_import (tools) permission.
-Go to Acquisitions and Add to a basket. 
-Select 'From a new file'
-You will be logged out as the user does not have percussion to visit that page.

Comment 1 Lucas Gass (lukeg) 2023-06-13 19:43:56 UTC

Created attachment 152322 [details] [review]
Bug 34002: Check for stage_marc_import permssion

-1 Log in to the staff client as a user who has  Acquisition management (acquisition) permissions but not the stage_marc_import (tools) permission.
-2 Go to Acquisitions and Add to a basket.
-3 Select 'From a new file'
-4 You will be logged out as the user does not have percussion to visit that page.
-5 Apply patch
-6 Try again, you will not see the link for 'From a new file' if you don't have the permssion.
-7 Give the user the stage_marc_import, you will now see the link

Comment 2 Sam Lau 2023-06-14 14:57:52 UTC

Created attachment 152340 [details] [review]
Bug 34002: Check for stage_marc_import permssion

-1 Log in to the staff client as a user who has  Acquisition management (acquisition) permissions but not the stage_marc_import (tools) permission.
-2 Go to Acquisitions and Add to a basket.
-3 Select 'From a new file'
-4 You will be logged out as the user does not have percussion to visit that page.
-5 Apply patch
-6 Try again, you will not see the link for 'From a new file' if you don't have the permssion.
-7 Give the user the stage_marc_import, you will now see the link

Signed-off-by: Sam Lau <samalau@gmail.com>

Comment 3 Katrin Fischer 2023-06-22 21:31:05 UTC

Created attachment 152601 [details] [review]
Bug 34002: Check for stage_marc_import permssion

-1 Log in to the staff client as a user who has  Acquisition management (acquisition) permissions but not the stage_marc_import (tools) permission.
-2 Go to Acquisitions and Add to a basket.
-3 Select 'From a new file'
-4 You will be logged out as the user does not have percussion to visit that page.
-5 Apply patch
-6 Try again, you will not see the link for 'From a new file' if you don't have the permssion.
-7 Give the user the stage_marc_import, you will now see the link

Signed-off-by: Sam Lau <samalau@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Comment 4 Tomás Cohen Arazi (tcohen) 2023-07-06 15:25:15 UTC

Pushed to master for 23.11.

Nice work everyone, thanks!

Comment 5 Martin Renvoize (ashimema) 2023-07-18 06:04:41 UTC

Thanks for all the hard work!

Pushed to 23.05.x for the next release

Comment 6 Matt Blenkinsop 2023-07-18 13:33:12 UTC

Nice work everyone!

Pushed to oldstable for 22.11.x