| Summary: | Patron image upload silently fails without cardnumber | ||
|---|---|---|---|
| Product: | Koha | Reporter: | David Cook <dcook> |
| Component: | Tools | Assignee: | Bugs List <koha-bugs> |
| Status: | NEW --- | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: |
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35344 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39535 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39536 |
||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 40457 | ||
|
Description
David Cook
2023-06-15 06:47:20 UTC
I suppose there are some minor changes that could be made that could get it over the line... (In reply to David Cook from comment #1) > I suppose there are some minor changes that could be made that could get it > over the line... Actually, I don't think so. I don't know what I was thinking back in June when I wrote this comment. While http://localhost:8081/cgi-bin/koha/members/moremember.pl does pass a borrowernumber, the handle_dir and handle_file functions are hard-coded to only accept cardnumber. Any change to just use borrowernumber would need to be tested, but then ./tools/picture-upload.pl isn't currently unit tested. But to unit test it you'd need to rewrite ./tools/picture-upload.pl, so it's just going to be too much work for too little gain. The workaround here is to just use a temporary dummy cardnumber for a patron when uploading a patron image. |