Bug 34018

Summary:	Patron image upload silently fails without cardnumber
Product:	Koha	Reporter:	David Cook <dcook>
Component:	Tools	Assignee:	Bugs List <koha-bugs>
Status:	NEW ---	QA Contact:	Testopia <testopia>
Severity:	enhancement
Priority:	P5 - low
Version:	Main
Hardware:	All
OS:	All
See Also:	https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35344
Change sponsored?:	---	Patch complexity:	---
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:
Circulation function:

Description David Cook 2023-06-15 06:47:20 UTC

If a borrower doesn't have a cardnumber, you can't upload a patron image via the Patrons module.

I realize this is because it leverages the /cgi-bin/koha/tools/picture-upload.pl tool which requires a file including cardnumbers or prompts for a cardnumber, but you should be able to use borrowernumber instead - at least via the Patron module.

--

The way to do this would be to refactor tools/picture-upload.pl to use a Perl module, and then create a REST API endpoint for uploading the patron image.

Comment 1 David Cook 2023-06-15 06:52:16 UTC

I suppose there are some minor changes that could be made that could get it over the line...

Comment 2 David Cook 2023-11-16 04:49:40 UTC

(In reply to David Cook from comment #1)
> I suppose there are some minor changes that could be made that could get it
> over the line...

Actually, I don't think so. I don't know what I was thinking back in June when I wrote this comment.

While http://localhost:8081/cgi-bin/koha/members/moremember.pl does pass a borrowernumber, the handle_dir and handle_file functions are hard-coded to only accept cardnumber. 

Any change to just use borrowernumber would need to be tested, but then ./tools/picture-upload.pl isn't currently unit tested.

But to unit test it you'd need to rewrite ./tools/picture-upload.pl, so it's just going to be too much work for too little gain.

The workaround here is to just use a temporary dummy cardnumber for a patron when uploading a patron image.

Comment 3 David Cook 2023-11-16 05:15:21 UTC

I've raised bug 35344 which warns if the patron is missing the cardnumber and prevents an attempt at uploading the patron image.

I think that's the most I'm going to do on this one without sponsorship. 

Going to change this from a bug to an enhancement...