Summary: | Two factor authentication (2FA) shows the wrong values for manual entry | ||
---|---|---|---|
Product: | Koha | Reporter: | David Cook <dcook> |
Component: | Authentication | Assignee: | David Cook <dcook> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | major | ||
Priority: | P5 - low | CC: | david, dpavlin, fridolin.somers, jonathan.druart, m.de.rooy, martin.renvoize, pedro.amorim, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: |
This fixes the details displayed for manually entering two-factor authentication (2FA) details into a 2FA application (when enabling 2FA). Currently, the wrong information is displayed - so you can't successfully add the account manually to your 2FA application.
|
|
Version(s) released in: |
23.11.00,23.05.01,22.11.09
|
Circulation function: | |
Bug Depends on: | 28786 | ||
Bug Blocks: | |||
Attachments: |
Bug 34028: Fix manual entry for two factor authentication
Bug 34028: Fix manual entry for two factor authentication Bug 34028: Fix manual entry for two factor authentication Bug 34028: Show the secret when registering from the auth screen |
Description
David Cook
2023-06-16 05:20:34 UTC
Created attachment 152398 [details] [review] Bug 34028: Fix manual entry for two factor authentication This patch changes the "Account" and "Key" display so that you can manually enter two factor authentication details into an authenticator app. The details are the same as those provided by scanning the QR code. Test plan: 0. Apply patch 1. Go to http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=TwoFactorAuthentication 2. Change setting to "Enable" 3. Go to http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=51 4. Click "More" on record toolbar and choose "Manage two-factor authentication" 5. Click "Enable two-factor authentication" 6. Scan the QR code into an authenticator app and note it creates an entry called "Centerville: Centerville_koha" 7. Manually enter an entry into an authenticator app (like Google Authenticator) 7a. Add the "Account" as shown on the Koha screen 7b. Add the "Key" as shown on the Koha screen 8. Note that the entries added by QR code and manual entry have the same label and both were accepted by the authenticator app *** Bug 31119 has been marked as a duplicate of this bug. *** *** Bug 30586 has been marked as a duplicate of this bug. *** Created attachment 152465 [details] [review] Bug 34028: Fix manual entry for two factor authentication This patch changes the "Account" and "Key" display so that you can manually enter two factor authentication details into an authenticator app. The details are the same as those provided by scanning the QR code. Test plan: 0. Apply patch 1. Go to http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=TwoFactorAuthentication 2. Change setting to "Enable" 3. Go to http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=51 4. Click "More" on record toolbar and choose "Manage two-factor authentication" 5. Click "Enable two-factor authentication" 6. Scan the QR code into an authenticator app and note it creates an entry called "Centerville: Centerville_koha" 7. Manually enter an entry into an authenticator app (like Google Authenticator) 7a. Add the "Account" as shown on the Koha screen 7b. Add the "Key" as shown on the Koha screen 8. Note that the entries added by QR code and manual entry have the same label and both were accepted by the authenticator app Signed-off-by: David Nind <david@davidnind.com> Created attachment 152473 [details] [review] Bug 34028: Fix manual entry for two factor authentication This patch changes the "Account" and "Key" display so that you can manually enter two factor authentication details into an authenticator app. The details are the same as those provided by scanning the QR code. Test plan: 0. Apply patch 1. Go to http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=TwoFactorAuthentication 2. Change setting to "Enable" 3. Go to http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=51 4. Click "More" on record toolbar and choose "Manage two-factor authentication" 5. Click "Enable two-factor authentication" 6. Scan the QR code into an authenticator app and note it creates an entry called "Centerville: Centerville_koha" 7. Manually enter an entry into an authenticator app (like Google Authenticator) 7a. Add the "Account" as shown on the Koha screen 7b. Add the "Key" as shown on the Koha screen 8. Note that the entries added by QR code and manual entry have the same label and both were accepted by the authenticator app Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Solid fix, works as expected. Passing QA Pushed to master for 23.11. Nice work everyone, thanks! Pushed to 23.05.x for 23.05.01 Key is missing on the auth screen: https://snipboard.io/PlARWt.jpg Created attachment 153009 [details] [review] Bug 34028: Show the secret when registering from the auth screen Waiting on follow-up to be pushed before we consider this for 22.11.x. Follow-up pushed to master. Thanks. @Frido can you please take a look at the follow-up for 23.05.x? (In reply to Pedro Amorim from comment #13) > @Frido can you please take a look at the follow-up for 23.05.x? Followup pushed to 23.05.x for 23.05.03 : Bug 34028: Show the secret when registering from the auth screen Nice work everyone! Pushed to 22.11.x for next release |