Summary: | z3950 responder additional options not coming through properly | ||
---|---|---|---|
Product: | Koha | Reporter: | Liz Rea <wizzyrea> |
Component: | Z39.50 / SRU / OpenSearch Servers | Assignee: | Liz Rea <wizzyrea> |
Status: | Pushed to oldstable --- | QA Contact: | Testopia <testopia> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | caroline.cyr-la-rose, david, fridolin.somers, hammat.wele, lucas, m.de.rooy, philippe.blouin |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
24.05.00,23.11.06,23.05.12
|
|
Circulation function: | |||
Attachments: |
Bug 34041 - z3950 responder additional options not coming through properly
Bug 34041 - z3950 responder additional options not coming through properly Bug 34041 - z3950 responder additional options not coming through properly Bug 34041: z3950 responder additional options not coming through properly Bug 34041: (follow-up) escape double dashes to prevent issues |
Description
Liz Rea
2023-06-16 17:50:48 UTC
Created attachment 152448 [details] [review] Bug 34041 - z3950 responder additional options not coming through properly This patch adds the <config> node that the z3950 responder starter script is looking for in the z3950/config.xml to the example code. To test: - verify that the <config> </config> is around the commented z3950_additional_options suggestion in the etc/z3950/config.xml file - bonus points, uncomment it and make sure you can start/stop/restart koha-z3950-responder with the example config. Added assignee. Testing notes (using KTD): 1. If I manually add the change to /etc/koha/sites/kohadev/z3950/config.xml and restart, I get some errors. I think the last config needs to be </config>? So this should be: <config> <z3950_responder_options>\-\-add-item-status k -t 5</z3950_responder_options> </config> 2. However, if I do that, then I can't get the z3950 responder to start using restart_all - get this: ... Error: Z39.50/SRU not running for kohadev: failed! ... I don't know enough about the Z3950 responder to test if it is running properly. Created attachment 164150 [details] [review] Bug 34041 - z3950 responder additional options not coming through properly This patch adds the <config> node that the z3950 responder starter script is looking for in the z3950/config.xml to the example code. To test: - verify that the <config> </config> is around the commented z3950_additional_options suggestion in the etc/z3950/config.xml file - copy the config stanza to the live file: /etc/koha/sites/kohadev/z3950/config.xml - restart_all - ps aux | grep z3950 - confirm the script has restarted - confirm the options: --add-item-status k -t 5 have been passed through Created attachment 164152 [details] [review] Bug 34041 - z3950 responder additional options not coming through properly This patch adds the <config> node that the z3950 responder starter script is looking for in the z3950/config.xml to the example code. To test: - verify that the <config> </config> is around the commented z3950_additional_options suggestion in the etc/z3950/config.xml file - copy the config stanza to the live file: /etc/koha/sites/kohadev/z3950/config.xml - restart_all - ps aux | grep z3950 - confirm the script has restarted - confirm the options: --add-item-status k -t 5 have been passed through Signed-off-by: David Nind <david@davidnind.com> I wonder if that could explain part of the problems dicussed on mailing list lately? Hammat, could you look at this Created attachment 166540 [details] [review] Bug 34041: z3950 responder additional options not coming through properly This patch adds the <config> node that the z3950 responder starter script is looking for in the z3950/config.xml to the example code. To test: - verify that the <config> </config> is around the commented z3950_additional_options suggestion in the etc/z3950/config.xml file - copy the config stanza to the live file: /etc/koha/sites/kohadev/z3950/config.xml - restart_all - ps aux | grep z3950 - confirm the script has restarted - confirm the options: --add-item-status k -t 5 have been passed through Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 166542 [details] [review] Bug 34041: (follow-up) escape double dashes to prevent issues Having double dashes inside a commmented block is not valid XML. This patch restores it, with an added message explaining it To test: 1. Run: $ xmllint etc/z3950/config.xml => FAIL: You get: etc/z3950/config.xml:5: parser error : Double hyphen within comment: <!-- <config> <z3950_responder_options> <z3950_responder_options>--add-item-status k -t 5</z3950_responder_options 2. Apply this patch 3. Repeat 1 => SUCCESS: All good! Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Should this be re-classified as a bug (not an enh)? Pushed for 24.05! Well done everyone, thank you! Pushed to 23.11.x for 23.11.06 Backported to 23.05.x for upcoming 23.05.12 |