Summary: | On detail.tt if item.permanent_location is NULL no shelving location will show | ||
---|---|---|---|
Product: | Koha | Reporter: | Lucas Gass (lukeg) <lucas> |
Component: | Circulation | Assignee: | Lucas Gass (lukeg) <lucas> |
Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
Severity: | minor | ||
Priority: | P5 - low | CC: | flyingendpaper, gmcharlt, kyle.m.hall |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34122 | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
23.11.00,23.05.02,22.11.08
|
Circulation function: | |
Attachments: |
Bug 34086: Show location on detail page when there is no permenant location
Bug 34086: Show location on detail page when there is no permenant location Bug 34086: Show location on detail page when there is no permenant location |
Description
Lucas Gass (lukeg)
2023-06-21 19:19:54 UTC
Created attachment 152538 [details] [review] Bug 34086: Show location on detail page when there is no permenant location To test: 1. Have some items without a permanent location. 2. Go to the staff detail page. 3. In the 'Home library' column notice the span .shelvingloc is empty. 4. Add a permanent location, now the shelvingloc is populated 5. Apply patch 6. The location should now show even when there is no permenant location. I am adding/removing the permanent location like so: -sudo koha-shell kohadev -update items set permanent_location = NULL; update items set permanent_location = 'GEN'; Created attachment 152574 [details] [review] Bug 34086: Show location on detail page when there is no permenant location To test: 1. Have some items without a permanent location. 2. Go to the staff detail page. 3. In the 'Home library' column notice the span .shelvingloc is empty. 4. Add a permanent location, now the shelvingloc is populated 5. Apply patch 6. The location should now show even when there is no permenant location. Signed-off-by: Sam Lau <samalau@gmail.com> I went through this the hard way adding a mapping for 952C on items.permanent_location and something seems to have got stuck in cache... but in the end all is well. Created attachment 153215 [details] [review] Bug 34086: Show location on detail page when there is no permenant location To test: 1. Have some items without a permanent location. 2. Go to the staff detail page. 3. In the 'Home library' column notice the span .shelvingloc is empty. 4. Add a permanent location, now the shelvingloc is populated 5. Apply patch 6. The location should now show even when there is no permenant location. Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 23.11. Nice work everyone, thanks! Thanks for all the hard work! Pushed to 23.05.x for the next release Nice work everyone! Pushed to oldstable for 22.11.x |