Bug 34097

Summary:	Using the three ellipses to set the date accessioned for an item repositions the screen to the top
Product:	Koha	Reporter:	Laura Escamilla <Laura.escamilla>
Component:	Cataloging	Assignee:	Phil Ringnalda <phil>
Status:	RESOLVED FIXED	QA Contact:	Katrin Fischer <katrin.fischer>
Severity:	minor
Priority:	P5 - low	CC:	barbara.johnson, lucas, m.de.rooy, phil
Version:	Main
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	---
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:	23.11.00,23.05.02,22.11.08,22.05.16
Circulation function:
Attachments:	Bug 34097 - Clicking ellipsis for dateaccessioned plugin shouldn't scroll up Bug 34097 - Clicking ellipsis for dateaccessioned plugin shouldn't scroll up Bug 34097: Prevent clicking ellipsis for dateaccessioned plugin from scrolling up

Description Laura Escamilla 2023-06-22 13:29:59 UTC

Steps to reproduce:
1. Select Cataloging from the home page
2. Search for a title
3. From the Actions button select Add/Edit items
4. From the Actions button for an existing item select Edit or just begin filling out the Add item form for a new item
5. Click on the three ellipses next to the 952|d field (date cataloged)
6. The screen repositions itself to the top rather than staying in the Add/Edit item area
7. The cataloger has to scroll back down the screen to get to their place in the Add item form

Comment 1 Phil Ringnalda 2023-06-27 22:59:25 UTC

Created attachment 152772 [details] [review]
Bug 34097 - Clicking ellipsis for dateaccessioned plugin shouldn't scroll up

Test plan:
1. Find a record with several items (in ktd "MacLaren's Gaelic
   self-taught" will do nicely
2. Click the Edit button next to one of the items
3. Click the "..." to the right of "d - Date acquired" and verify that the
   page doesn't scroll up to the top, and that the current date is
   inserted in the field
4. Click the "..." to the right of "w - Price effective from" and verify
   that the page doesn't scroll up and the current date is inserted

Comment 2 Sam Lau 2023-06-28 18:22:20 UTC

Created attachment 152838 [details] [review]
Bug 34097 - Clicking ellipsis for dateaccessioned plugin shouldn't scroll up

Test plan:
1. Find a record with several items (in ktd "MacLaren's Gaelic
   self-taught" will do nicely
2. Click the Edit button next to one of the items
3. Click the "..." to the right of "d - Date acquired" and verify that the
   page doesn't scroll up to the top, and that the current date is
   inserted in the field
4. Click the "..." to the right of "w - Price effective from" and verify
   that the page doesn't scroll up and the current date is inserted

Signed-off-by: Sam Lau <samalau@gmail.com>

Comment 3 Katrin Fischer 2023-07-09 13:15:38 UTC

Created attachment 153214 [details] [review]
Bug 34097: Prevent clicking ellipsis for dateaccessioned plugin from scrolling up

Test plan:
1. Find a record with several items (in ktd "MacLaren's Gaelic
   self-taught" will do nicely
2. Click the Edit button next to one of the items
3. Click the "..." to the right of "d - Date acquired" and verify that the
   page doesn't scroll up to the top, and that the current date is
   inserted in the field
4. Click the "..." to the right of "w - Price effective from" and verify
   that the page doesn't scroll up and the current date is inserted

Signed-off-by: Sam Lau <samalau@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Comment 4 Katrin Fischer 2023-07-09 13:17:03 UTC

Hi Phil, 

thx for the patch!

* Commit title does not start with 'Bug XXXXX: ' - a0e428f101

I've updated your commit message, also making sure it describes the fix, not the problem.

Comment 5 Tomás Cohen Arazi (tcohen) 2023-07-14 12:01:23 UTC

Pushed to master for 23.11.

Nice work everyone, thanks!

Comment 6 Martin Renvoize (ashimema) 2023-07-18 11:52:17 UTC

Thanks for all the hard work!

Pushed to 23.05.x for the next release

Comment 7 Matt Blenkinsop 2023-07-18 14:48:13 UTC

Nice work everyone!

Pushed to oldstable for 22.11.x

Comment 8 Lucas Gass (lukeg) 2023-09-13 20:12:06 UTC

Backported to 22.05.x for upcoming 22.05.16