Summary: | When items are added on order, item selection gets lost on editing items | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | Acquisitions | Assignee: | Nick Clemens (kidclamp) <nick> |
Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
Severity: | normal | ||
Priority: | P5 - low | CC: | fridolin.somers, michaela.sieber, nick, pedro.amorim, tomascohen |
Version: | Main | Keywords: | regression |
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
23.11.00,23.05.03
|
|
Circulation function: | |||
Bug Depends on: | 8179 | ||
Bug Blocks: | |||
Attachments: |
Bug 34108: Preserve checked orders after item editing
Bug 34108: Preserve checked orders after item editing Bug 34108: Preserve checked orders after item editing Bug 34108: Preserve checked orders after item editing |
Description
Katrin Fischer
2023-06-23 07:32:14 UTC
To test: * Create a basket with 'items created on receive' * Add an order line with multiple items to it * Close basket * Receive shipment * Add invoice information * Receive through receive link in the table * Check some items * Click on the "Edit" link and make some change to the item * Save --> Checkboxes have disappeared (In reply to Katrin Fischer from comment #1) > To test: > * Create a basket with 'items created on receive' > * Add an order line with multiple items to it > * Close basket > * Receive shipment > * Add invoice information > * Receive through receive link in the table > * Check some items Just to clarify: following your steps I marked the orderline as including 10 items for "Perl best practices /", but I don't see a list of items to check, but the cataloguing form. Did you mean adding (say) 3 items using the form and THEN checking them? Also, it was marked as '22.11', but depending on 8179, could you please check if this is introduced by 8179, or something we just didn't fix with the change? Hm, the problem here is that I confused 'on order' and 'on receive' - must have been a long day. Revised test plan: To test: * Create a basket with 'items on order' * Add an order line with multiple items to it * Close basket * Receive shipment * Add invoice information * Receive through receive link in the table * Check some items using the checkboxes * Click on the "Edit" link and make some change to the item in the form * Save --> Checkboxes have disappeared 22.11 was by mistake, it doesn't have the multi-receive. This was intended for master. (In reply to Katrin Fischer from comment #5) > 22.11 was by mistake, it doesn't have the multi-receive. This was intended > for master. I also verfified now that this works in 22.11 - checkboxes are kept, so this is a regression. Created attachment 154218 [details] [review] Bug 34108: Preserve checked orders after item editing The js that buils the new row after editing expects to receive a value '_checked' indicating if theitem was selected. The 'item' variable used to create the row after edit comes from the api and doesn't include this. We need to inspect the previous html before building the new row to confirm the box wa checked To test: 1 - Create a basket with 'items created on receive' 2 - Add an order line with multiple items to it 3 - Close basket 4 - Receive shipment 5 - Add invoice information 6 - Receive through receive link in the table 7 - Check some items 8 - Click on the "Edit" link and make some change to the item 9 - Save 10 - Checkboxes have disappeared 11 - Cancel receipt 12 - Apply patch 13 - Reload the page 14 - Repeat 7-9 15 - Checkbox is preserved Created attachment 154220 [details] [review] Bug 34108: Preserve checked orders after item editing The js that buils the new row after editing expects to receive a value '_checked' indicating if theitem was selected. The 'item' variable used to create the row after edit comes from the api and doesn't include this. We need to inspect the previous html before building the new row to confirm the box wa checked To test: 1 - Create a basket with 'items created on receive' 2 - Add an order line with multiple items to it 3 - Close basket 4 - Receive shipment 5 - Add invoice information 6 - Receive through receive link in the table 7 - Check some items 8 - Click on the "Edit" link and make some change to the item 9 - Save 10 - Checkboxes have disappeared 11 - Cancel receipt 12 - Apply patch 13 - Reload the page 14 - Repeat 7-9 15 - Checkbox is preserved Signed-off-by: Sam Lau <samalau@gmail.com> Created attachment 154225 [details] [review] Bug 34108: Preserve checked orders after item editing The js that buils the new row after editing expects to receive a value '_checked' indicating if theitem was selected. The 'item' variable used to create the row after edit comes from the api and doesn't include this. We need to inspect the previous html before building the new row to confirm the box wa checked To test: 1 - Create a basket with 'items created on receive' 2 - Add an order line with multiple items to it 3 - Close basket 4 - Receive shipment 5 - Add invoice information 6 - Receive through receive link in the table 7 - Check some items 8 - Click on the "Edit" link and make some change to the item 9 - Save 10 - Checkboxes have disappeared 11 - Cancel receipt 12 - Apply patch 13 - Reload the page 14 - Repeat 7-9 15 - Checkbox is preserved Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Created attachment 154262 [details] [review] Bug 34108: Preserve checked orders after item editing The js that buils the new row after editing expects to receive a value '_checked' indicating if theitem was selected. The 'item' variable used to create the row after edit comes from the api and doesn't include this. We need to inspect the previous html before building the new row to confirm the box wa checked To test: 1 - Create a basket with 'items created on receive' 2 - Add an order line with multiple items to it 3 - Close basket 4 - Receive shipment 5 - Add invoice information 6 - Receive through receive link in the table 7 - Check some items 8 - Click on the "Edit" link and make some change to the item 9 - Save 10 - Checkboxes have disappeared 11 - Cancel receipt 12 - Apply patch 13 - Reload the page 14 - Repeat 7-9 15 - Checkbox is preserved Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Small patch, great effect - thanks a lot, Nick! Pushed to master for 23.11. Nice work everyone, thanks! Pushed to 23.05.x for 23.05.03 Missing bug 8179 on 22.11.x. Doesn't apply. Not pushing. |