Bug 34122

Summary:	Updating location changes location of all related records
Product:	Koha	Reporter:	Laura Escamilla <Laura.escamilla>
Component:	Cataloging	Assignee:	Laura Escamilla <Laura.escamilla>
Status:	RESOLVED WORKSFORME	QA Contact:	Testopia <testopia>
Severity:	enhancement
Priority:	P5 - low	CC:	kebliss, m.de.rooy, nick, tphythian
Version:	22.11
Hardware:	All
OS:	All
See Also:	https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34086
Change sponsored?:	---	Patch complexity:	---
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:
Circulation function:
Attachments:	Bug 34122: Fix for shelving locations that were applying to all item records. Bug 34122: Fix for shelving locations that were applying to all item records.

Description Laura Escamilla 2023-06-26 16:26:05 UTC

Partners have reported that updating the shelving location on one item updates all of the items in the record regardless of their branch location. For example, Branch A has Item A located in the Genealogy department, and Branch B has it in their Reference section. Changing the location in Branch A to Genealogy will also change the shelving location for Branch B to Genealogy even if Branch B doesn't have a Genealogy shelving location.

Comment 1 Laura Escamilla 2023-06-28 19:05:49 UTC

Created attachment 152839 [details] [review]
Bug 34122: Fix for shelving locations that were applying to all item records.

Test plan:
1. Create a bib record that has at least 3 items. 
2. Change the shelving location of item 1 and do not add shelving locations to the other items. 
3. View the bib record in the catalog, all three items will have the shelving location that was assigned to item 1.
4. Apply patch
5. Refresh the page on the bib record. Only item 1 should have the shelving location set. 
6. Sign off! :D

Comment 2 Laura Escamilla 2023-06-28 20:08:43 UTC

Revised/reworded test plan:
1. Create a bib record that has at least 3 items. 
2. Change the shelving location of item 1 and do not add shelving locations
to the other items. 
3. View the bib record for the items in catalogue/detail.pl, all three items will have the shelving location that was assigned to item 1. However, if you look at the items in cataloguing/additem.pl, only item 1 will show the shelving location change. Item 2 and 3 will still show a blank shelving location. 
4. Apply patch
5. Repeat step 3. Only item 1 should have a shelving location visible in both catalogue/detail.pl and cataloguing/additem.pl.
6. Sign off! :D

Comment 3 Sam Lau 2023-06-29 14:41:46 UTC

Created attachment 152871 [details] [review]
Bug 34122: Fix for shelving locations that were applying to all item records.

Signed-off-by: Sam Lau <samalau@gmail.com>

Comment 4 Nick Clemens (kidclamp) 2023-06-30 11:01:53 UTC

If I set  UpdateItemLocationOnCheckin to:
_ALL_: CART

And checkin an item with no location set, the permanent_location is NULL and the location is CART, but nothing displays for the item

Comment 5 Katrin Fischer 2023-07-16 12:19:08 UTC

Hi Laura, 

please make sure to also add the problem description and test plan to the commit (see: https://wiki.koha-community.org/wiki/Commit_messages)

A common issue here is to think that git bz edit does change the commit message 
too, but it will only post it here.


(In reply to Nick Clemens from comment #4)
> If I set  UpdateItemLocationOnCheckin to:
> _ALL_: CART
> 
> And checkin an item with no location set, the permanent_location is NULL and
> the location is CART, but nothing displays for the item

Can you explain this a bit more? Could it be bug 34086 ?