| Summary: | Improve in-page navigation on table settings page | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | RESOLVED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | caroline.cyr-la-rose, matt.blenkinsop |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28917 | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
23.11.00,23.05.02
|
|
| Circulation function: | |||
| Attachments: |
Bug 34124: Improve in-page navigation on table settings page
Bug 34124: Improve in-page navigation on table settings page Bug 34124: Improve in-page navigation on table settings page Bug 34124: Improve in-page navigation on table settings page |
||
|
Description
Owen Leonard
2023-06-26 20:27:56 UTC
Created attachment 152703 [details] [review] Bug 34124: Improve in-page navigation on table settings page This patch adds links to the table settings page so that the user can jump directly to a particular table within a page section. The patch also changes the logic of when in-page links are displayed: I think it makes sense not to show a "Jump to page" link when there is only one page. The page will show a "Jump to table" link only if there is only one table. To test, apply the patch and go to Adinistration -> Table settings. - Expand and check multiple sections. - In the "Administration" section, there are multiple pages. - Check that the "Jump to page" links work correctly. - In the "Catalog" section, there is only one page: "detail." - Check that the "Jump to table" links work correctly. Created attachment 152872 [details] [review] Bug 34124: Improve in-page navigation on table settings page This patch adds links to the table settings page so that the user can jump directly to a particular table within a page section. The patch also changes the logic of when in-page links are displayed: I think it makes sense not to show a "Jump to page" link when there is only one page. The page will show a "Jump to table" link only if there is only one table. To test, apply the patch and go to Adinistration -> Table settings. - Expand and check multiple sections. - In the "Administration" section, there are multiple pages. - Check that the "Jump to page" links work correctly. - In the "Catalog" section, there is only one page: "detail." - Check that the "Jump to table" links work correctly. Signed-off-by: Sam Lau <samalau@gmail.com> Created attachment 152926 [details] [review] Bug 34124: Improve in-page navigation on table settings page This patch adds links to the table settings page so that the user can jump directly to a particular table within a page section. The patch also changes the logic of when in-page links are displayed: I think it makes sense not to show a "Jump to page" link when there is only one page. The page will show a "Jump to table" link only if there is only one table. To test, apply the patch and go to Administration -> Table settings. - Expand and check multiple sections. - In the "Administration" section, there are multiple pages. - Check that the "Jump to page" links work correctly. - In the "Catalog" section, there is only one page: "detail." - Check that the "Jump to table" links work correctly. Signed-off-by: Sam Lau <samalau@gmail.com> Created attachment 153115 [details] [review] Bug 34124: Improve in-page navigation on table settings page This patch adds links to the table settings page so that the user can jump directly to a particular table within a page section. The patch also changes the logic of when in-page links are displayed: I think it makes sense not to show a "Jump to page" link when there is only one page. The page will show a "Jump to table" link only if there is only one table. To test, apply the patch and go to Administration -> Table settings. - Expand and check multiple sections. - In the "Administration" section, there are multiple pages. - Check that the "Jump to page" links work correctly. - In the "Catalog" section, there is only one page: "detail." - Check that the "Jump to table" links work correctly. Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for 23.11. Nice work everyone, thanks! Thanks for all the hard work! Pushed to 23.05.x for the next release Enhancement - not backporting to 22.11.x Nice work everyone! Nothing to change in the manual that I can see. Feel free to reopen with details if I'm wrong. |