Summary: | ILL requests table won't load if request_placed date is null | ||
---|---|---|---|
Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
Component: | ILL | Assignee: | Pedro Amorim <pedro.amorim> |
Status: | RESOLVED FIXED | QA Contact: | |
Severity: | major | ||
Priority: | P5 - low | CC: | pedro.amorim |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
23.11.00,23.05.02,22.11.08
|
|
Bug Depends on: | 22440 | ||
Bug Blocks: | |||
Attachments: |
Bug 34130: Make requested_date nullable in api definition
Bug 34130: Make requested_date nullable in api definition |
Description
Nick Clemens (kidclamp)
2023-06-27 12:33:42 UTC
Created attachment 152737 [details] [review] Bug 34130: Make requested_date nullable in api definition Created attachment 152741 [details] [review] Bug 34130: Make requested_date nullable in api definition This patch allows the requested_date for an ILL request to be NULL to accomodate older data To test: 1 - Install the Koha 2 Koha ILL plugin: https://gitlab.com/koha-community/plugins/koha-plugin-ill-koha 2 - Enable the ILL system preference 3 - Force an ILL request with minimal data from backend: INSERT INTO illrequests (borrowernumber,biblio_id,branchcode,backend,status) VALUES (5,3,'CPL','Koha','placed'); 4 - View the ILL table 5 - Error: {"message":"Expected string - got null.","path":"\/body\/0\/requested_date"} 6 - Apply patch 7 - Table loads successfully Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Trivial change, passing QA to allow RM to agree (or not) Pushed to master for 23.11. Nice work everyone, thanks! Thanks for all the hard work! Pushed to 23.05.x for the next release Nice work everyone! Pushed to 22.11.x for next release |