Bug 34130

Summary: ILL requests table won't load if request_placed date is null
Product: Koha Reporter: Nick Clemens (kidclamp) <nick>
Component: ILLAssignee: Pedro Amorim <pedro.amorim>
Status: RESOLVED FIXED QA Contact:
Severity: major    
Priority: P5 - low CC: pedro.amorim
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.02,22.11.08
Bug Depends on: 22440    
Bug Blocks:    
Attachments: Bug 34130: Make requested_date nullable in api definition
Bug 34130: Make requested_date nullable in api definition

Description Nick Clemens (kidclamp) 2023-06-27 12:33:42 UTC
We are seeing older requests that have no date placed break the display of the table
Comment 1 Pedro Amorim 2023-06-27 13:23:36 UTC
Created attachment 152737 [details] [review]
Bug 34130: Make requested_date nullable in api definition
Comment 2 Nick Clemens (kidclamp) 2023-06-27 13:40:10 UTC
Created attachment 152741 [details] [review]
Bug 34130: Make requested_date nullable in api definition

This patch allows the requested_date for an ILL request to be NULL to accomodate
older data

To test:
1 - Install the Koha 2 Koha ILL plugin:
    https://gitlab.com/koha-community/plugins/koha-plugin-ill-koha
2 - Enable the ILL  system preference
3 - Force an ILL request with minimal data from backend:
    INSERT INTO illrequests (borrowernumber,biblio_id,branchcode,backend,status) VALUES (5,3,'CPL','Koha','placed');
4 - View the ILL table
5 - Error:
    {"message":"Expected string - got null.","path":"\/body\/0\/requested_date"}
6 - Apply patch
7 - Table loads successfully

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 3 Nick Clemens (kidclamp) 2023-06-27 13:40:33 UTC
Trivial change, passing QA to allow RM to agree (or not)
Comment 4 Tomás Cohen Arazi 2023-06-29 14:08:57 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 5 Martin Renvoize 2023-07-17 14:47:08 UTC
Thanks for all the hard work!

Pushed to 23.05.x for the next release
Comment 6 Pedro Amorim 2023-07-18 11:55:31 UTC
Nice work everyone!

Pushed to 22.11.x for next release