|
Description
Pedro Amorim
2023-06-27 12:46:14 UTC
Created attachment 152727 [details] [review] Bug 34131: Update breadcrumbs and side bar Update plugins-home accordingly if tool plugins only filter is being used or not Update breadcrumbs for plugins-disabled page Created attachment 152728 [details] [review] Bug 34131: Add 'current' class on correct side menu link This changes the way we're looking for the correct menu item to set as active. If we don't find an exact match for path+params, we attempt to set 'current' to just matching on path. What this does is it sets the 'Plugins' menu item as active, even if the url is 'plugins-home.pl?method=report Created attachment 152745 [details] [review] Bug 34131: Update breadcrumbs and side bar Update plugins-home accordingly if tool plugins only filter is being used or not. Update breadcrumbs for plugins-disabled page Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 152746 [details] [review] Bug 34131: Add 'current' class on correct side menu link This changes the way we're looking for the correct menu item to set as active. If we don't find an exact match for path+params, we attempt to set 'current' to just matching on path. What this does is it sets the 'Plugins' menu item as active, even if the url is 'plugins-home.pl?method=report Signed-off-by: Owen Leonard <oleonard@myacpl.org> Can you detail what is doing the second patch? On http://kohadev-intra.mydnsname.org:8081/cgi-bin/koha/plugins/plugins-home.pl?method=ill_availability_services ".current" is not set Created attachment 153150 [details] ill_availability_services (In reply to Jonathan Druart from comment #5) > Can you detail what is doing the second patch? > > On > http://kohadev-intra.mydnsname.org:8081/cgi-bin/koha/plugins/plugins-home. > pl?method=ill_availability_services ".current" is not set The patch makes it so that the ".current" class is applied to the parent side menu item even if a URL param exists, instead of matching on exact URL, potentially not containing URL params, and failing. I can't reproduce what you're reporting, it shows for me. See attached. I'm preparing a couple follow-up QA patches, will update bug status shortly. Created attachment 153151 [details] [review] Bug 34131: (QA follow-up): Add 'ill_availability_services' to method filter check Created attachment 153152 [details] [review] Bug 34131: (QA follow-up) Update page title to reflect breadcrumbs and side-menu behaviour Created attachment 153164 [details] [review] Bug 34131: Update breadcrumbs and side bar Update plugins-home accordingly if tool plugins only filter is being used or not. Update breadcrumbs for plugins-disabled page Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 153165 [details] [review] Bug 34131: Add 'current' class on correct side menu link This changes the way we're looking for the correct menu item to set as active. If we don't find an exact match for path+params, we attempt to set 'current' to just matching on path. What this does is it sets the 'Plugins' menu item as active, even if the url is 'plugins-home.pl?method=report Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 153166 [details] [review] Bug 34131: (QA follow-up): Add 'ill_availability_services' to method filter check Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 153167 [details] [review] Bug 34131: (QA follow-up) Update page title to reflect breadcrumbs and side-menu behaviour Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for 23.11. Nice work everyone, thanks! Thanks for all the hard work! Pushed to 23.05.x for the next release Nice work everyone! Pushed to oldstable for 22.11.x |