| Summary: | ILL table should be sorted by request id descending by default | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
| Component: | ILL | Assignee: | Pedro Amorim <pedro.amorim> |
| Status: | CLOSED FIXED | QA Contact: | |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | fridolin.somers, lucas, magnus, martin.renvoize, nick, pedro.amorim |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
23.11.00,23.05.03,22.11.09
|
|
| Circulation function: | |||
| Attachments: |
Bug 34133: Set default sort on first column (ID) desc
Lowest numbers at the top Bug 34133: Set default sort on first column (ID) desc Bug 34133: Set default sort on first column (ID) desc |
||
|
Description
Nick Clemens (kidclamp)
2023-06-27 14:36:03 UTC
Created attachment 152751 [details] [review] Bug 34133: Set default sort on first column (ID) desc I applied the patch, restarted all the things, opened the main ILL page in an "incognito" window. When I look at the JS file the change has been applied, but the table still shows the lowest numbers at the top. Could I be missing something? Created attachment 152848 [details]
Lowest numbers at the top
Should this actually be sorting on the placed on date as a posed to ID? Test plan: Before applying patch: * Open incognito at /cgi-bin/koha/ill/ill-requests.pl, * Verify order is by ASC (lowest ID first) * Close incognito Apply patch, then: * Open incognito at /cgi-bin/koha/ill/ill-requests.pl, * Verify order is by DESC (highest ID first) Did the test plan myself on both Google Chrome and Firefox. Can you please give it another go, Magnus? Created attachment 152886 [details] [review] Bug 34133: Set default sort on first column (ID) desc Test plan: Before applying patch: * Open incognito at /cgi-bin/koha/ill/ill-requests.pl, * Verify order is by ASC (lowest ID first) * Close incognito Apply patch, then: * Open incognito at /cgi-bin/koha/ill/ill-requests.pl, * Verify order is by DESC (highest ID first) Signed-off-by: Magnus Enger <magnus@libriotech.no> Followed the test plan from Bugzilla, and added it above. Works as advertised. (In reply to Martin Renvoize from comment #4) > Should this actually be sorting on the placed on date as a posed to ID? Would that make a difference in practice? Hey guys any chance for a PQA here? Something that needs improving? Thanks! Created attachment 153541 [details] [review] Bug 34133: Set default sort on first column (ID) desc Test plan: Before applying patch: * Open incognito at /cgi-bin/koha/ill/ill-requests.pl, * Verify order is by ASC (lowest ID first) * Close incognito Apply patch, then: * Open incognito at /cgi-bin/koha/ill/ill-requests.pl, * Verify order is by DESC (highest ID first) Signed-off-by: Magnus Enger <magnus@libriotech.no> Followed the test plan from Bugzilla, and added it above. Works as advertised. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Pushed to master for 23.11. Nice work everyone, thanks! Pushed to 23.05.x for 23.05.03 Nice work everyone! Pushed to 22.11.x for next release |