Summary: | Show the icons for selected tab to the left of the search bar in the staff interface | ||
---|---|---|---|
Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
Component: | Staff interface | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | fridolin.somers, gmcharlt |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Medium patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
23.11.00
|
|
Circulation function: | |||
Attachments: |
Mockup
Bug 34135: Show the icons for selected tab to the left of the search bar in the staff interface Bug 34135: Show the icons for selected tab to the left of the search bar in the staff interface Bug 34135: Show the icons for selected tab to the left of the search bar in the staff interface Bug 34135: Show the icons for selected tab to the left of the search bar in the staff interface |
Description
Nick Clemens (kidclamp)
2023-06-27 17:13:51 UTC
Created attachment 152768 [details]
Mockup
Like this, but better
Created attachment 152784 [details] [review] Bug 34135: Show the icons for selected tab to the left of the search bar in the staff interface This patch modifies header search forms so that the form label has the same icon used by the "tab" link. The patch also improves the responsive behavior of the header search by using the icon as the form label when the browser window is narrow enough to hide the label text. I've added the "aria-hidden" attribute to other icons in the modified templates and made the "fa-fw" class consistent for all tab icons. To test, apply the patch and rebuild the staff interface CSS. Clear your browser cache if necessary. View the header search form at various browser sizes to confirm that content is shown and hidden correctly. Test at least one page which uses each of the modified header search includes: - Staff client home page - Acquisitions -> Acquisitions home - Vendor -> - Basket -> Add to basket -> From suggestion - Contracts - Administration -> - Budgets - Currencies - Desks (with UseCirculationDesks enabled) - System preferences - Z39.50/SRU servers - Catalog advanced search - Search results - Authorities -> Authorities home - Cataloging -> Cataloging home - Circulation -> Check out - E-resource management (with ERMModule enabled) - Patrons -> Patrons home - Serials -> Serials home - Tools -> Notices I wanted to offer this patch for testing to see if other agreed with this change. I think it could be helpful for quick recognition of context for circulation desk users especially. If folks don't like the additional icons, an alternative would be to show the icon only if the browser width was narrow enough that the form label text is hidden. Created attachment 152788 [details] [review] Bug 34135: Show the icons for selected tab to the left of the search bar in the staff interface This patch modifies header search forms so that the form label has the same icon used by the "tab" link. The patch also improves the responsive behavior of the header search by using the icon as the form label when the browser window is narrow enough to hide the label text. I've added the "aria-hidden" attribute to other icons in the modified templates and made the "fa-fw" class consistent for all tab icons. To test, apply the patch and rebuild the staff interface CSS. Clear your browser cache if necessary. View the header search form at various browser sizes to confirm that content is shown and hidden correctly. Test at least one page which uses each of the modified header search includes: - Staff client home page - Acquisitions -> Acquisitions home - Vendor -> - Basket -> Add to basket -> From suggestion - Contracts - Administration -> - Budgets - Currencies - Desks (with UseCirculationDesks enabled) - System preferences - Z39.50/SRU servers - Catalog advanced search - Search results - Authorities -> Authorities home - Cataloging -> Cataloging home - Circulation -> Check out - E-resource management (with ERMModule enabled) - Patrons -> Patrons home - Serials -> Serials home - Tools -> Notices Signed-off-by: Nick Clemens <nick@bywatersolutions.com> I love it! Leaving NSO for another opinion, but adding my support Created attachment 153108 [details] [review] Bug 34135: Show the icons for selected tab to the left of the search bar in the staff interface This patch modifies header search forms so that the form label has the same icon used by the "tab" link. The patch also improves the responsive behavior of the header search by using the icon as the form label when the browser window is narrow enough to hide the label text. I've added the "aria-hidden" attribute to other icons in the modified templates and made the "fa-fw" class consistent for all tab icons. To test, apply the patch and rebuild the staff interface CSS. Clear your browser cache if necessary. View the header search form at various browser sizes to confirm that content is shown and hidden correctly. Test at least one page which uses each of the modified header search includes: - Staff client home page - Acquisitions -> Acquisitions home - Vendor -> - Basket -> Add to basket -> From suggestion - Contracts - Administration -> - Budgets - Currencies - Desks (with UseCirculationDesks enabled) - System preferences - Z39.50/SRU servers - Catalog advanced search - Search results - Authorities -> Authorities home - Cataloging -> Cataloging home - Circulation -> Check out - E-resource management (with ERMModule enabled) - Patrons -> Patrons home - Serials -> Serials home - Tools -> Notices Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Created attachment 155079 [details] [review] Bug 34135: Show the icons for selected tab to the left of the search bar in the staff interface This patch modifies header search forms so that the form label has the same icon used by the "tab" link. The patch also improves the responsive behavior of the header search by using the icon as the form label when the browser window is narrow enough to hide the label text. I've added the "aria-hidden" attribute to other icons in the modified templates and made the "fa-fw" class consistent for all tab icons. To test, apply the patch and rebuild the staff interface CSS. Clear your browser cache if necessary. View the header search form at various browser sizes to confirm that content is shown and hidden correctly. Test at least one page which uses each of the modified header search includes: - Staff client home page - Acquisitions -> Acquisitions home - Vendor -> - Basket -> Add to basket -> From suggestion - Contracts - Administration -> - Budgets - Currencies - Desks (with UseCirculationDesks enabled) - System preferences - Z39.50/SRU servers - Catalog advanced search - Search results - Authorities -> Authorities home - Cataloging -> Cataloging home - Circulation -> Check out - E-resource management (with ERMModule enabled) - Patrons -> Patrons home - Serials -> Serials home - Tools -> Notices Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for 23.11. Nice work everyone, thanks! Enhancement not pushed to 23.05.x |