Summary: | Patron search broken | ||
---|---|---|---|
Product: | Koha | Reporter: | Justin Dowswell <justin> |
Component: | Patrons | Assignee: | Bugs List <koha-bugs> |
Status: | In Discussion --- | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | bc, gmcharlt, jonathan.druart, justin, kyle.m.hall, m.de.rooy, nick, paul.derscheid |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34147 | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: | Bug 34145: Allow access the logged in branch's limited data |
Description
Justin Dowswell
2023-06-28 12:41:08 UTC
How can I reproduce this? I think there is a confusion in Koha::Libraries->search_filtered, and we don't add the logged in library. Created attachment 153051 [details] [review] Bug 34145: Allow access the logged in branch's limited data Justin, could you confirm this patch fixes your problem? Nick, does this patch seem correct to you? The name is a killer :) sub libraries_where_can_see_things (In reply to Jonathan Druart from comment #5) > Nick, does this patch seem correct to you? I don't recreate, what is the setup? Also, without view_borrower_infos_from_any_libraries you can log into another branch, but still can't see their patrons, so I don't think we should be adding the logged in branch. Can you explain why we should? Can we get some non-code summary on what happens here and a test plan? I didn't recreate, the patch was just a guess. See also bug 34147. At the moment it looks like we have no information on how to make this bug appear. I have tested the patron search a lot for various bugs and couldn't detect an issue or this bug. I am downgrading this one. Please provide more information! * What is the exact version you are seeing this in * What is your setup? (IndependentBranches? Library groups?) I am not sure how useful this is but I found an instance where this can be recreated. If the branchcode on the borrowers table is in an different case to the branchcode on the branches table this problem can occur. MySQL doesn't care about case sensitivity but when javascript gets a hold of it branchcode != BRANCHCODE. Updating the borrowers table (or branches table) to make all the same case (upper or lower) resolved the issue. 23.11 I am not sure how useful this is but I found an instance where this can be recreated. If the branchcode on the borrowers table is in an different case to the branchcode on the branches table this problem can occur. MySQL doesn't care about case sensitivity but when javascript gets a hold of it branchcode != BRANCHCODE. Updating the borrowers table (or branches table) to make all the same case (upper or lower) resolved the issue. 23.11 |