| Summary: | mainpage.pl shows background jobs to users without manage_background_jobs permission | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Lucas Gass (lukeg) <lucas> |
| Component: | Staff interface | Assignee: | Bugs List <koha-bugs> |
| Status: | CLOSED WORKSFORME | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | gmcharlt |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
On mainpage.pl we show the count of background jobs only to users who do not have the manage_background_jobs permission: unless ( $logged_in_user->has_permission( { parameters => 'manage_background_jobs' } ) ) { my $already_ran_jobs = Koha::BackgroundJobs->search( { borrowernumber => $logged_in_user->borrowernumber } )->count ? 1 : 0; $template->param( already_ran_jobs => $already_ran_jobs ); } This seems backwards to me. Is there a reason to show the count only to users without the permission?