Bug 34171

Summary: item_barcode_transform does not work when moving items
Product: Koha Reporter: Michaela Sieber <michaela.sieber>
Component: CatalogingAssignee: Katrin Fischer <katrin.fischer>
Status: Pushed to oldstable --- QA Contact: Marcel de Rooy <m.de.rooy>
Severity: normal    
Priority: P5 - low CC: fridolin.somers, katrin.fischer, m.de.rooy
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.05,22.11.12
Bug Depends on: 26351    
Bug Blocks:    
Attachments: Bug 34171: Use barcodedecode when attaching items to another record
Bug 34171: Use barcodedecode when attaching items to another record
Bug 34171: Use barcodedecode when attaching items to another record

Description Michaela Sieber 2023-06-30 12:20:24 UTC
When moving an item to another biblio (cataloguing/moveitem.pl?) the 
scanned item barcode is not transformed.
Comment 1 Katrin Fischer 2023-07-21 15:30:59 UTC
Created attachment 153800 [details] [review]
Bug 34171: Use barcodedecode when attaching items to another record

Bug 26351 added barcodecode that transforms scanned barcodes either
by using itemBarcodeInputFilter  or via a plugin to various pages in
Koha, including checkout and checkin. But the feature for attaching
items to a new record was missed.

To test:
* Add an item with barcode "ab" to any record
* Set itemBarcodeInputFilter to "Remove spaces from"
* Search for another record in the catalog
* Edit > attach item > "a b"
* The item is not found.
* Apply patch, restart_all
* Try again with "a b"
* Verify that the item is found and attached to the record
Comment 2 ByWater Sandboxes 2023-07-21 19:08:17 UTC
Created attachment 153815 [details] [review]
Bug 34171: Use barcodedecode when attaching items to another record

Bug 26351 added barcodecode that transforms scanned barcodes either
by using itemBarcodeInputFilter  or via a plugin to various pages in
Koha, including checkout and checkin. But the feature for attaching
items to a new record was missed.

To test:
* Add an item with barcode "ab" to any record
* Set itemBarcodeInputFilter to "Remove spaces from"
* Search for another record in the catalog
* Edit > attach item > "a b"
* The item is not found.
* Apply patch, restart_all
* Try again with "a b"
* Verify that the item is found and attached to the record

Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Comment 3 Michaela Sieber 2023-07-21 19:10:43 UTC
Thanks Katrin!

Tested with Systempreference itemBarcodeInputFilter 
and 
bywatersolutions koha-plugin-barcode-transformer 

Signed Off :-)
Comment 4 Marcel de Rooy 2023-09-29 09:20:45 UTC
Created attachment 156371 [details] [review]
Bug 34171: Use barcodedecode when attaching items to another record

Bug 26351 added barcodecode that transforms scanned barcodes either
by using itemBarcodeInputFilter  or via a plugin to various pages in
Koha, including checkout and checkin. But the feature for attaching
items to a new record was missed.

To test:
* Add an item with barcode "ab" to any record
* Set itemBarcodeInputFilter to "Remove spaces from"
* Search for another record in the catalog
* Edit > attach item > "a b"
* The item is not found.
* Apply patch, restart_all
* Try again with "a b"
* Verify that the item is found and attached to the record

Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 5 Tomás Cohen Arazi 2023-10-20 14:48:32 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 6 Fridolin Somers 2023-10-25 22:19:09 UTC
Set as normal bug instead of enhancement
Comment 7 Fridolin Somers 2023-10-25 22:19:49 UTC
Pushed to 23.05.x for 23.05.05
Comment 8 Matt Blenkinsop 2023-11-13 14:19:54 UTC
Nice work everyone!

Pushed to oldstable for 22.11.x