| Summary: | "Document type" in suggestions form should have an empty entry | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
| Component: | Templates | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | RESOLVED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | jonathan.druart, lucas |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
23.11.00,23.05.02,22.11.08,22.05.16
|
|
| Circulation function: | |||
| Attachments: |
Bug 34184: Add empty option for suggestion "document type"
Bug 34184: Add empty option for suggestion "document type" Bug 34184: Add empty option for suggestion "document type" |
||
|
Description
Katrin Fischer
2023-07-01 10:03:40 UTC
Created attachment 153050 [details] [review] Bug 34184: Add empty option for suggestion "document type" Currently when editing a suggestion, the document type will preselect to the first entry as we don't have an empty entry. This can lead to data errors easily. Test plan: Create a new suggestion => Notice that "document type" is empty by default, pick one Edit it again => Notice that the value is kept and empty can be picked, pick empty Edit again => Empty is selected and saved in DB Created attachment 153054 [details] [review] Bug 34184: Add empty option for suggestion "document type" Currently when editing a suggestion, the document type will preselect to the first entry as we don't have an empty entry. This can lead to data errors easily. Test plan: Create a new suggestion => Notice that "document type" is empty by default, pick one Edit it again => Notice that the value is kept and empty can be picked, pick empty Edit again => Empty is selected and saved in DB Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 153210 [details] [review] Bug 34184: Add empty option for suggestion "document type" Currently when editing a suggestion, the document type will preselect to the first entry as we don't have an empty entry. This can lead to data errors easily. Test plan: Create a new suggestion => Notice that "document type" is empty by default, pick one Edit it again => Notice that the value is kept and empty can be picked, pick empty Edit again => Empty is selected and saved in DB Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Sometimes the fix is really obvious - once you see it! Pushed to master for 23.11. Nice work everyone, thanks! Thanks for all the hard work! Pushed to 23.05.x for the next release Nice work everyone! Pushed to oldstable for 22.11.x Backported to 22.05.x for upcoming 22.05.16 |