Bug 34209

Summary:	Follow up on Bug 28726 - move whole search header div into checkbox column condition
Product:	Koha	Reporter:	Michael Hafen <michael.hafen>
Component:	Label/patron card printing	Assignee:	Michael Hafen <michael.hafen>
Status:	CLOSED FIXED	QA Contact:	Katrin Fischer <katrin.fischer>
Severity:	trivial
Priority:	P5 - low	CC:	jonathan.druart, lucas
Version:	Main
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	Trivial patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:	23.11.00,23.05.02,22.11.08
Circulation function:
Bug Depends on:	28726
Bug Blocks:
Attachments:	Bug 28726: Follow up - move whole 'select all ...' div into checkbox column condition Bug 34209: Follow up on Bug 28726 - move whole 'select all ...' header into condition Bug 34209: Follow up on Bug 28726 - move whole 'select all ...' header into condition

Description Michael Hafen 2023-07-05 17:25:20 UTC

Created attachment 153075 [details] [review]
Bug 28726: Follow up - move whole 'select all ...' div into checkbox column condition

In the patron search popup from pages that don't have a checkbox in the search results table there is an empty div above the table.  This div holds the 'Select all ...' features when there is a checkbox column in the table.

Comment 1 Jonathan Druart 2023-07-11 06:55:24 UTC

Thanks, Michael.

Comment 2 Owen Leonard 2023-07-12 11:29:11 UTC

Created attachment 153350 [details] [review]
Bug 34209: Follow up on Bug 28726 - move whole 'select all ...' header into condition

Move the whole search header div into the checkbox column condition, so
that other patron search popups don't have an empty div.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Comment 3 Katrin Fischer 2023-07-12 21:16:20 UTC

Created attachment 153388 [details] [review]
Bug 34209: Follow up on Bug 28726 - move whole 'select all ...' header into condition

Move the whole search header div into the checkbox column condition, so
that other patron search popups don't have an empty div.

To test:
* Activate the ERM module
* Create a new agreement
* Search for a user using the pop-up search
* Verify there is an empty div showing as grey box above the table
* Go to tools > label creator > new batch
* Search for patrons
* Verify the box isn't empty and shows the select all ... options
* Apply patch
* Repeat steps, verify the empty div is gone and the options remain

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Comment 4 Katrin Fischer 2023-07-12 21:16:43 UTC

Please make sure to add a test plan to your patches, working out what I need to test/look at without many hints costs time I cannot spend elsewhere.

Comment 5 Tomás Cohen Arazi (tcohen) 2023-07-14 18:24:20 UTC

Pushed to master for 23.11.

Nice work everyone, thanks!

Comment 6 Martin Renvoize (ashimema) 2023-07-18 11:52:26 UTC

Thanks for all the hard work!

Pushed to 23.05.x for the next release

Comment 7 Matt Blenkinsop 2023-07-18 15:29:05 UTC

Nice work everyone!

Pushed to oldstable for 22.11.x