Summary: | Add +strings for GET /api/v1/biblios/:biblio_id/items | ||
---|---|---|---|
Product: | Koha | Reporter: | Lucas Gass (lukeg) <lucas> |
Component: | REST API | Assignee: | Bugs List <koha-bugs> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | jonathan.druart, kebliss, martin.renvoize, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
23.11.00,23.05.02,22.11.08
|
|
Circulation function: | |||
Bug Depends on: | 26635 | ||
Bug Blocks: | 33568 | ||
Attachments: |
Bug 34211: Add tests
Bug 34211: Add +strings for GET /api/v1/biblios/:biblio_id/items Bug 34211: Add +strings for GET /api/v1/biblios/:biblio_id/items Bug 34211: Add tests Bug 34211: Add +strings for GET /api/v1/biblios/:biblio_id/items |
Description
Lucas Gass (lukeg)
2023-07-05 20:14:31 UTC
\o/ (In reply to Jonathan Druart from comment #2) > This is done somewhere in bug 33568. Great! In that case should we just mark this one as a duplicate? We can, unless it's something you would like to backport. In that case I can extract the relevant part and attach it here. You decide! :) Put it here! Created attachment 153092 [details] [review] Bug 34211: Add tests Created attachment 153093 [details] [review] Bug 34211: Add +strings for GET /api/v1/biblios/:biblio_id/items Allow to embed stringified version of attributes for the "Get items for a biblio" endpoint Test plan: curl -u koha:koha --request GET 'http://localhost:8081/api/v1/biblios/47/items' --header "Content-Type: application/json" --header "x-koha-embed: +strings" | jq Created attachment 153099 [details] [review] Bug 34211: Add +strings for GET /api/v1/biblios/:biblio_id/items Allow to embed stringified version of attributes for the "Get items for a biblio" endpoint Test plan: curl -u koha:koha --request GET 'http://localhost:8081/api/v1/biblios/47/items' --header "Content-Type: application/json" --header "x-koha-embed: +strings" | jq Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Created attachment 153405 [details] [review] Bug 34211: Add tests Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 153406 [details] [review] Bug 34211: Add +strings for GET /api/v1/biblios/:biblio_id/items Allow to embed stringified version of attributes for the "Get items for a biblio" endpoint Test plan: curl -u koha:koha --request GET 'http://localhost:8081/api/v1/biblios/47/items' --header "Content-Type: application/json" --header "x-koha-embed: +strings" | jq Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Pushed to master for 23.11. Nice work everyone, thanks! Reading the discussion here, it looks like we already decided to backport this.. who am I to argue ;). Thanks for all the hard work! Pushed to 23.05.x for the next release Nice work everyone! Pushed to oldstable for 22.11.x |