Summary: | Bug 23336 follow-up code improvements | ||
---|---|---|---|
Product: | Koha | Reporter: | Martin Renvoize (ashimema) <martin.renvoize> |
Component: | Architecture, internals, and plumbing | Assignee: | Bugs List <koha-bugs> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | jonathan.druart |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
23.11.00
|
|
Circulation function: | |||
Bug Depends on: | 23336 | ||
Bug Blocks: | |||
Attachments: |
Bug 34212: Replace Koha::Checkouts->find with $item->checkout
Bug 34212: Replace Koha::Checkouts->find with $item->checkout Bug 34212: Compare strings with eq instead of == Bug 34212: Fix tests |
Description
Martin Renvoize (ashimema)
2023-07-06 06:36:19 UTC
Created attachment 153084 [details] [review] Bug 34212: Replace Koha::Checkouts->find with $item->checkout No need to call get_from_storage here? I don't think it's needed but I would confirm it just in case. Created attachment 153145 [details] [review] Bug 34212: Replace Koha::Checkouts->find with $item->checkout Created attachment 153146 [details] [review] Bug 34212: Compare strings with eq instead of == And don't ignore warnings next time ;) Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 153147 [details] [review] Bug 34212: Fix tests Not sure what we were trying to do, but apparently we only use the keys to generate the id string. How did "please" end up here? Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Going straight through to PQA as these are really just minor follow-ups to squash warnings and improve a tiny piece of code style on bug 23336. Pushed to master for 23.11. Nice work everyone, thanks! (In reply to Jonathan Druart from comment #3) > I don't think it's needed but I would confirm it just in case. I suspected that.. but if we do that I don't understand what the benefit is to just calling the find method. |