Bug 34217

Summary: Add missing cypress tests for vendors in agreements and licenses
Product: Koha Reporter: Pedro Amorim <pedro.amorim>
Component: ERMAssignee: Pedro Amorim <pedro.amorim>
Status: CLOSED FIXED QA Contact:
Severity: enhancement    
Priority: P5 - low CC: fridolin.somers, jonathan.druart, jonathan.field, martin.renvoize, matt.blenkinsop, pedro.amorim, tomascohen
Version: MainKeywords: Academy
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33480
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00
Circulation function:
Attachments: Bug 34217: Add vendor tests for agreements
Bug 34217: Add vendor tests for agreements
Bug 34217: (QA follow-up) Clean-up old unused code
Bug 34217: Add vendor tests for licenses
Bug 34217: Add vendor tests for agreements
Bug 34217: (QA follow-up) Clean-up old unused code
Bug 34217: Add vendor tests for licenses
Bug 34217: Add vendor tests for agreements
Bug 34217: (QA follow-up) Clean-up old unused code
Bug 34217: Add vendor tests for licenses
Bug 34217: Add vendor tests for agreements and licenses

Description Pedro Amorim 2023-07-06 10:13:51 UTC
Bug 34206 made it evident we are missing tests for vendors in agreements and licenses.
Comment 1 Pedro Amorim 2023-07-06 10:15:05 UTC
Created attachment 153088 [details] [review]
Bug 34217: Add vendor tests for agreements
Comment 2 Pedro Amorim 2023-07-06 10:15:23 UTC
Missing the same for licenses.
Comment 3 Pedro Amorim 2023-07-10 12:49:58 UTC
Created attachment 153266 [details] [review]
Bug 34217: Add vendor tests for agreements
Comment 4 Pedro Amorim 2023-07-20 13:50:23 UTC
Created attachment 153722 [details] [review]
Bug 34217: (QA follow-up) Clean-up old unused code

Spotted this and didn't want to open a new bug for it
Comment 5 Pedro Amorim 2023-08-25 10:20:44 UTC
Created attachment 154794 [details] [review]
Bug 34217: Add vendor tests for licenses
Comment 6 Pedro Amorim 2023-08-25 10:24:27 UTC
Test plan, k-t-d, run:
cypress run
Comment 7 Jonathan Druart 2023-08-31 07:18:03 UTC
Created attachment 154996 [details] [review]
Bug 34217: Add vendor tests for agreements

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 8 Jonathan Druart 2023-08-31 07:18:06 UTC
Created attachment 154997 [details] [review]
Bug 34217: (QA follow-up) Clean-up old unused code

Spotted this and didn't want to open a new bug for it

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 9 Jonathan Druart 2023-08-31 07:18:09 UTC
Created attachment 154998 [details] [review]
Bug 34217: Add vendor tests for licenses

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 10 Tomás Cohen Arazi (tcohen) 2023-09-05 17:30:13 UTC
Please rebase.
Comment 11 Jonathan Druart 2023-09-06 09:10:07 UTC
Created attachment 155257 [details] [review]
Bug 34217: Add vendor tests for agreements

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 12 Jonathan Druart 2023-09-06 09:10:11 UTC
Created attachment 155258 [details] [review]
Bug 34217: (QA follow-up) Clean-up old unused code

Spotted this and didn't want to open a new bug for it

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 13 Jonathan Druart 2023-09-06 09:10:14 UTC
Created attachment 155259 [details] [review]
Bug 34217: Add vendor tests for licenses

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 14 Pedro Amorim 2023-09-06 09:12:07 UTC Comment hidden (obsolete)
Comment 15 Pedro Amorim 2023-09-06 09:14:35 UTC
Little mid-air collision there, all sorted!
Comment 16 Tomás Cohen Arazi (tcohen) 2023-09-06 12:58:05 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 17 Fridolin Somers 2023-09-08 19:18:51 UTC
Enhancement not pushed to 23.05.x