| Summary: | Running log viewer for only Catalog module loads wrong side navbar | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jason Robb <jrobb> |
| Component: | Tools | Assignee: | Lucas Gass (lukeg) <lucas> |
| Status: | RESOLVED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | trivial | ||
| Priority: | P5 - low | CC: | alexander.blanchard, lucas |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
23.11.00,23.05.02,22.11.08
|
|
| Circulation function: | |||
| Attachments: |
Bug 34220: Only show biblio-view-menu.inc if their is an associated bib
Bug 34220: Only show biblio-view-menu.inc if their is an associated bib Bug 34220: Only show biblio-view-menu.inc if their is an associated bib |
||
|
Description
Jason Robb
2023-07-06 14:24:51 UTC
Created attachment 153206 [details] [review] Bug 34220: Only show biblio-view-menu.inc if their is an associated bib To test: - Go to Tools > Log viewer - Uncheck All modules - Check the 'Catalog' module - Make sure "To screen in the browser" is the selected output - Click Submit After the page loads, instead of the tools side navbar appearing on the left, a 'catalog detail' type navbar (Normal, MARC, ISBD, etc.) is present with links that error out as there's no associated bibnumber. -Apply patch -Try again, you should not see the biblio-view-menu -Try one more time but this time add a valid biblionumber to the Object: field. Now the biblio-view-menu should show with links to that particular bib. Created attachment 153262 [details] [review] Bug 34220: Only show biblio-view-menu.inc if their is an associated bib To test: - Go to Tools > Log viewer - Uncheck All modules - Check the 'Catalog' module - Make sure "To screen in the browser" is the selected output - Click Submit After the page loads, instead of the tools side navbar appearing on the left, a 'catalog detail' type navbar (Normal, MARC, ISBD, etc.) is present with links that error out as there's no associated bibnumber. -Apply patch -Try again, you should not see the biblio-view-menu -Try one more time but this time add a valid biblionumber to the Object: field. Now the biblio-view-menu should show with links to that particular bib. Works as advertised. Signed-off-by: Alexander Blanchard <alexander.blanchard@ptfs-europe.com> Created attachment 153303 [details] [review] Bug 34220: Only show biblio-view-menu.inc if their is an associated bib To test: - Go to Tools > Log viewer - Uncheck All modules - Check the 'Catalog' module - Make sure "To screen in the browser" is the selected output - Click Submit After the page loads, instead of the tools side navbar appearing on the left, a 'catalog detail' type navbar (Normal, MARC, ISBD, etc.) is present with links that error out as there's no associated bibnumber. -Apply patch -Try again, you should not see the biblio-view-menu -Try one more time but this time add a valid biblionumber to the Object: field. Now the biblio-view-menu should show with links to that particular bib. Works as advertised. Signed-off-by: Alexander Blanchard <alexander.blanchard@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 23.11. Nice work everyone, thanks! Thanks for all the hard work! Pushed to 23.05.x for the next release Nice work everyone! Pushed to oldstable for 22.11.x |