| Summary: | Deleting an EDIFACT ordering account throws an error | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Matt Blenkinsop <matt.blenkinsop> |
| Component: | Acquisitions | Assignee: | Matt Blenkinsop <matt.blenkinsop> |
| Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
| Severity: | trivial | ||
| Priority: | P5 - low | CC: | lucas |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
23.11.00,23.05.02,22.11.08
|
|
| Circulation function: | |||
| Attachments: |
Bug 34261: Add missing argument to show_account
Bug 34261: Add missing argument to show_account Bug 34261: Add missing argument to show_account |
||
|
Description
Matt Blenkinsop
2023-07-12 13:21:42 UTC
Created attachment 153360 [details] [review] Bug 34261: Add missing argument to show_account This patch fixes a missing $crypt in the show_account function when deleting an edifact ordering account. Test plan: 1) In system preferences search for EDIFACT and change EDIFACT to Enable 2) Navigate to Administration > EDI accounts 3) Create a dummy account 4) Try deleting the account using the delete button in the actions column on the far right 5) An error should be thrown - "Can't call method "decrypt_hex" on an undefined value" 6) Apply patch 7) Try deleting the account again 8) This time it should work and show the confirmation dialog box 9) Sign off Created attachment 153366 [details] [review] Bug 34261: Add missing argument to show_account This patch fixes a missing $crypt in the show_account function when deleting an edifact ordering account. Test plan: 1) In system preferences search for EDIFACT and change EDIFACT to Enable 2) Navigate to Administration > EDI accounts 3) Create a dummy account 4) Try deleting the account using the delete button in the actions column on the far right 5) An error should be thrown - "Can't call method "decrypt_hex" on an undefined value" 6) Apply patch 7) Try deleting the account again 8) This time it should work and show the confirmation dialog box 9) Sign off Signed-off-by: Sam Lau <samalau@gmail.com> Created attachment 153387 [details] [review] Bug 34261: Add missing argument to show_account This patch fixes a missing $crypt in the show_account function when deleting an edifact ordering account. Test plan: 1) In system preferences search for EDIFACT and change EDIFACT to Enable 2) Navigate to Administration > EDI accounts 3) Create a dummy account 4) Try deleting the account using the delete button in the actions column on the far right 5) An error should be thrown - "Can't call method "decrypt_hex" on an undefined value" 6) Apply patch 7) Try deleting the account again 8) This time it should work and show the confirmation dialog box 9) Sign off Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 23.11. Nice work everyone, thanks! Thanks for all the hard work! Pushed to 23.05.x for the next release Nice work everyone! Pushed to oldstable for 22.11.x No variable named "$crypt" in 22.05.x edi_accounts.pl script, no backport. |