Summary: | Add a button to easily toggle between advanced/basic cataloging editors | ||
---|---|---|---|
Product: | Koha | Reporter: | Lucas Gass (lukeg) <lucas> |
Component: | Cataloging | Assignee: | Lucas Gass (lukeg) <lucas> |
Status: | RESOLVED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | barbara.johnson, blawlor, caroline.cyr-la-rose, esther.melander, fridolin.somers, m.de.rooy, mspinney, oleonard, phil, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Caroline Cyr La Rose | Documentation submission: | https://gitlab.com/koha-community/koha-manual/-/merge_requests/860 |
Text to go in the release notes: |
When the advanced cataloging editor is activated using `EnableAdvancedCatalogingEditor`, there is now a nice toggle button in the upper right corner of the cataloguing module when editing a record that allows to easily switch between the normal and the advanced editor.
|
Version(s) released in: |
23.11.00
|
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 35651 | ||
Attachments: |
Bug 34275: Add toggle switch for basic/advanced cataloging editors
Bug 34275: Add toggle switch for basic/advanced cataloging editors Bug 34275: Add toggle switch for basic/advanced cataloging editors Bug 34275: Add toggle switch for basic/advanced cataloging editors Bug 34275: Add toggle switch for basic/advanced cataloging editors Bug 34275: Add toggle switch for basic/advanced cataloging editors Bug 34275: Add toggle switch for basic/advanced cataloging editors Bug 34275: Add toggle switch for basic/advanced cataloging editors Bug 34275: (follow-up) Restore the rest of the changes Bug 34275: Add toggle switch for basic/advanced cataloging editors |
Description
Lucas Gass (lukeg)
2023-07-13 17:50:15 UTC
Created attachment 153426 [details] [review] Bug 34275: Add toggle switch for basic/advanced cataloging editors To test: 1. Apply patch and regenerate CSS. (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface) 2. Turn on EnableAdvancedCatalogingEditor. 3. Go to cataloging > 'New record' 4. In the upper left notice a new toggle switch labeled 'Editor:'. 5. Try toggling the switch back and forth to move between editors. Verify it works correecly. 6. Try editing an existing record and make sure the toggle works well when editing records. 7. Try the other method of switch editors, Settings > Switch to basic/advanced editor. Make sure it works the same as always 8. Turn off EnableAdvancedCatalogingEditor, make sure the toggle button is no longer present. Created attachment 153522 [details] [review] Bug 34275: Add toggle switch for basic/advanced cataloging editors To test: 1. Apply patch and regenerate CSS. (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface) 2. Turn on EnableAdvancedCatalogingEditor. 3. Go to cataloging > 'New record' 4. In the upper left notice a new toggle switch labeled 'Editor:'. 5. Try toggling the switch back and forth to move between editors. Verify it works correecly. 6. Try editing an existing record and make sure the toggle works well when editing records. 7. Try the other method of switch editors, Settings > Switch to basic/advanced editor. Make sure it works the same as always 8. Turn off EnableAdvancedCatalogingEditor, make sure the toggle button is no longer present. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> This works great and will be a timesaver. Looks like you accidentally included something from work on another patch, since the hunk commenting out part of koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt doesn't fit this bug. Created attachment 154471 [details] [review] Bug 34275: Add toggle switch for basic/advanced cataloging editors To test: 1. Apply patch and regenerate CSS. (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface) 2. Turn on EnableAdvancedCatalogingEditor. 3. Go to cataloging > 'New record' 4. In the upper left notice a new toggle switch labeled 'Editor:'. 5. Try toggling the switch back and forth to move between editors. Verify it works correecly. 6. Try editing an existing record and make sure the toggle works well when editing records. 7. Try the other method of switch editors, Settings > Switch to basic/advanced editor. Make sure it works the same as always 8. Turn off EnableAdvancedCatalogingEditor, make sure the toggle button is no longer present. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> (In reply to Phil Ringnalda from comment #4) > Looks like you accidentally included something from work on another patch, > since the hunk commenting out part of > koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt doesn't fit > this bug. Good catch Phil, thanks! Created attachment 154472 [details] [review] Bug 34275: Add toggle switch for basic/advanced cataloging editors To test: 1. Apply patch and regenerate CSS. (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface) 2. Turn on EnableAdvancedCatalogingEditor. 3. Go to cataloging > 'New record' 4. In the upper left notice a new toggle switch labeled 'Editor:'. 5. Try toggling the switch back and forth to move between editors. Verify it works correecly. 6. Try editing an existing record and make sure the toggle works well when editing records. 7. Try the other method of switch editors, Settings > Switch to basic/advanced editor. Make sure it works the same as always 8. Turn off EnableAdvancedCatalogingEditor, make sure the toggle button is no longer present. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Whilst the functionality here works nicely, I'm not sure about the styling myself. I think I'd either prefer a 'Switch to X editor' button that contextually sets 'X' or an 'Advanced editor: TOGGLE' with a narrower simple toggle switch rather than the large toggle the includes the text within it. Tagging Owen for that more artistic eye ;P (In reply to Martin Renvoize from comment #8) > Whilst the functionality here works nicely, I'm not sure about the styling > myself. > > I think I'd either prefer a 'Switch to X editor' button that contextually > sets 'X' or an 'Advanced editor: TOGGLE' with a narrower simple toggle > switch rather than the large toggle the includes the text within it. > > Tagging Owen for that more artistic eye ;P That makes sense. I'll come back to this one ASAP. For now I'll set to FQA. Created attachment 155706 [details] [review] Bug 34275: Add toggle switch for basic/advanced cataloging editors To test: 1. Apply patch and regenerate CSS. (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface) 2. Turn on EnableAdvancedCatalogingEditor. 3. Go to cataloging > 'New record' 4. In the upper left notice a new toggle switch labeled 'Editor:'. 5. Try toggling the switch back and forth to move between editors. Verify it works correecly. 6. Try editing an existing record and make sure the toggle works well when editing records. 7. Try the other method of switch editors, Settings > Switch to basic/advanced editor. Make sure it works the same as always 8. Turn off EnableAdvancedCatalogingEditor, make sure the toggle button is no longer present. (In reply to Martin Renvoize from comment #8) > Whilst the functionality here works nicely, I'm not sure about the styling > myself. > > I think I'd either prefer a 'Switch to X editor' button that contextually > sets 'X' or an 'Advanced editor: TOGGLE' with a narrower simple toggle > switch rather than the large toggle the includes the text within it. > > Tagging Owen for that more artistic eye ;P Martin, maybe my latest patch is more in line with what you envision? Created attachment 156124 [details] [review] Bug 34275: Add toggle switch for basic/advanced cataloging editors To test: 1. Apply patch and regenerate CSS. (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface) 2. Turn on EnableAdvancedCatalogingEditor. 3. Go to cataloging > 'New record' 4. In the upper left notice a new toggle switch labeled 'Editor:'. 5. Try toggling the switch back and forth to move between editors. Verify it works correecly. 6. Try editing an existing record and make sure the toggle works well when editing records. 7. Try the other method of switch editors, Settings > Switch to basic/advanced editor. Make sure it works the same as always 8. Turn off EnableAdvancedCatalogingEditor, make sure the toggle button is no longer present. Signed-off-by: Eesther <esther@bywatersolutions.com> Created attachment 156125 [details] [review] Bug 34275: Add toggle switch for basic/advanced cataloging editors To test: 1. Apply patch and regenerate CSS. (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface) 2. Turn on EnableAdvancedCatalogingEditor. 3. Go to cataloging > 'New record' 4. In the upper left notice a new toggle switch labeled 'Editor:'. 5. Try toggling the switch back and forth to move between editors. Verify it works correecly. 6. Try editing an existing record and make sure the toggle works well when editing records. 7. Try the other method of switch editors, Settings > Switch to basic/advanced editor. Make sure it works the same as always 8. Turn off EnableAdvancedCatalogingEditor, make sure the toggle button is no longer present. Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> I was about to say, I don't like the GUI implementation... and then the yarn build kicked in :) Created attachment 158142 [details] [review] Bug 34275: Add toggle switch for basic/advanced cataloging editors To test: 1. Apply patch and regenerate CSS. (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface) 2. Turn on EnableAdvancedCatalogingEditor. 3. Go to cataloging > 'New record' 4. In the upper left notice a new toggle switch labeled 'Editor:'. 5. Try toggling the switch back and forth to move between editors. Verify it works correecly. 6. Try editing an existing record and make sure the toggle works well when editing records. 7. Try the other method of switch editors, Settings > Switch to basic/advanced editor. Make sure it works the same as always 8. Turn off EnableAdvancedCatalogingEditor, make sure the toggle button is no longer present. Signed-off-by: Eesther <esther@bywatersolutions.com> Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 23.11. Nice work everyone, thanks! Somehow the new nice styling is missing for me, even after running yarn build and restart all on current master. This looks like there's patches missing here to me... the one patch on the bug now only adds a template block with a checkbox.. I'm not seeing the actually functionality tied to it anywhere.. or the css I am not sure how the patch got mangled, but apparently it did. Can we restore the missing files from the original patch? Created attachment 158537 [details] [review] Bug 34275: (follow-up) Restore the rest of the changes Created attachment 158538 [details] [review] Bug 34275: Add toggle switch for basic/advanced cataloging editors To test: 1. Apply patch and regenerate CSS. (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface) 2. Turn on EnableAdvancedCatalogingEditor. 3. Go to cataloging > 'New record' 4. In the upper left notice a new toggle switch labeled 'Editor:'. 5. Try toggling the switch back and forth to move between editors. Verify it works correecly. 6. Try editing an existing record and make sure the toggle works well when editing records. 7. Try the other method of switch editors, Settings > Switch to basic/advanced editor. Make sure it works the same as always 8. Turn off EnableAdvancedCatalogingEditor, make sure the toggle button is no longer present. Signed-off-by: Eesther <esther@bywatersolutions.com> Thank you, Lucas! I can confirm it looks and works nicely now in current dev version. Enhancement not pushed to 23.05.x |