Summary: | UI issue on checkin page when checking the forgive fines checkbox | ||
---|---|---|---|
Product: | Koha | Reporter: | Lucas Gass (lukeg) <lucas> |
Component: | Circulation | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
Severity: | minor | ||
Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, kyle.m.hall, pedro.amorim |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34572 | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
23.11.00,23.05.03,22.11.09
|
|
Circulation function: | |||
Attachments: |
screenshot of the problem
Bug 34289: Add missing class to one condition of the checkin template Bug 34289: Add missing class to one condition of the checkin template Bug 34289: Add missing class to one condition of the checkin template |
Created attachment 153570 [details] [review] Bug 34289: Add missing class to one condition of the checkin template The markup of the checkin template varies depending on the conditions of the operation, and in one case the barcode field was missing the "barcode" class. This patch adds it. To test, apply the patch and make sure the finesMode system preference is enabled. - Go to returns.pl (/cgi-bin/koha/circ/returns.pl) - Expand the the options so you see 'Forgive overdue charges'. - Check that box and check in an item - After checkin, the barcode field should keep the same style it had before the transaction. - Note: The yellow background of the input when the "Forgive" checkbox is checked is to be expected. Created attachment 154103 [details] [review] Bug 34289: Add missing class to one condition of the checkin template The markup of the checkin template varies depending on the conditions of the operation, and in one case the barcode field was missing the "barcode" class. This patch adds it. To test, apply the patch and make sure the finesMode system preference is enabled. - Go to returns.pl (/cgi-bin/koha/circ/returns.pl) - Expand the the options so you see 'Forgive overdue charges'. - Check that box and check in an item - After checkin, the barcode field should keep the same style it had before the transaction. - Note: The yellow background of the input when the "Forgive" checkbox is checked is to be expected. Signed-off-by: Sam Lau <samalau@gmail.com> Created attachment 154110 [details] [review] Bug 34289: Add missing class to one condition of the checkin template The markup of the checkin template varies depending on the conditions of the operation, and in one case the barcode field was missing the "barcode" class. This patch adds it. To test, apply the patch and make sure the finesMode system preference is enabled. - Go to returns.pl (/cgi-bin/koha/circ/returns.pl) - Expand the the options so you see 'Forgive overdue charges'. - Check that box and check in an item - After checkin, the barcode field should keep the same style it had before the transaction. - Note: The yellow background of the input when the "Forgive" checkbox is checked is to be expected. Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 23.11. Nice work everyone, thanks! Since we have now : [% IF ( exemptfine ) %] <input name="barcode" id="barcode" size="14" placeholder="Enter item barcode" class="barcode focus input-warning" type="text" /> [% ELSIF ( dropboxmode ) %] <input name="barcode" id="barcode" size="14" placeholder="Enter item barcode" class="barcode focus input-warning" /> [% ELSE %] There is no difference between those two lines since type="text" is default behavior. Maybe merge into [% IF ( exemptfine || dropboxmode ) %] (In reply to Fridolin Somers from comment #5) > Maybe merge into [% IF ( exemptfine || dropboxmode ) %] Bug 34572 @Frido this bug appears to have been pushed to 23.05.x but not yet updated on here on bugzilla. (In reply to Owen Leonard from comment #6) > (In reply to Fridolin Somers from comment #5) > > > Maybe merge into [% IF ( exemptfine || dropboxmode ) %] > > Bug 34572 Great :D (In reply to Pedro Amorim from comment #7) > @Frido this bug appears to have been pushed to 23.05.x but not yet updated > on here on bugzilla. Oups indeed sorry Pushed to 23.05.x for 23.05.03 Nice work everyone! Pushed to 22.11.x for next release |
Created attachment 153509 [details] screenshot of the problem To recreate: 1. Turn on fines mode 2. Go to returns.pl (/cgi-bin/koha/circ/returns.pl) 3. Expand the the options so you see 'Forgive overdue charges'. 4. Check that box and check in an item 5. The item is checked in but now the input "Enter item barcode" is smaller than it should be and has a yellow background.