| Summary: | Item->store tests on itemlost>0 | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Marcel de Rooy <m.de.rooy> |
| Component: | Architecture, internals, and plumbing | Assignee: | Bugs List <koha-bugs> |
| Status: | NEW --- | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | andrew, jonathan.druart, martin.renvoize, nick |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33608 | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
|
Description
Marcel de Rooy
2023-07-19 14:49:56 UTC
Discussion comes actually from 33608 btw. I can't recall ever running into any lost item functionality that depended on positive vs negative itemlost values. History is: commit dd1eec2715b465 commit 0005f6bad36319 which does not make a lot of sense at the end. This is current MASTER:
# If item was lost and has now been found,
# reverse any list item charges if necessary.
if ( exists $updated_columns{itemlost}
and $updated_columns{itemlost} <= 0
and $pre_mod_item->itemlost > 0 )
{
$self->_set_found_trigger($pre_mod_item);
}
I actually do not understand the test here for <= 0 too. Imo should be =0 only.
(In reply to Jonathan Druart from comment #3) > History is: > > commit dd1eec2715b465 > commit 0005f6bad36319 > > which does not make a lot of sense at the end. $charge eq $lostvalue Strange test? Not reading the definitive answer here for making the distinction? (In reply to Marcel de Rooy from comment #5) > $charge eq $lostvalue > Strange test? This seems correct. misc/cronjobs/longoverdue.pl 60 'c|charge=s' => \$charge, 146 =item B<--charge | -c> 147 148 This specifies what lost value triggers Koha to charge the account for the lost item. 238 $PERL5LIB/misc/cronjobs/longoverdue.pl --lost 60=2 --charge 2 239 Would set LOST=2 after 60 days (up to one year), and charge the account when setting LOST=2. (In reply to Jonathan Druart from comment #6) > (In reply to Marcel de Rooy from comment #5) > > $charge eq $lostvalue > > Strange test? > > This seems correct. Ah thanks. Bit of confusing parameter. I was thinking of an amount or so. |