Bug 34351

Summary: ILL list table - access_url column content should be clickable
Product: Koha Reporter: Pedro Amorim <pedro.amorim>
Component: ILLAssignee: Pedro Amorim <pedro.amorim>
Status: Needs documenting --- QA Contact: Katrin Fischer <katrin.fischer>
Severity: normal    
Priority: P5 - low CC: fridolin.somers, jeremy.evans, magnus, nick, pedro.amorim, tomascohen
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: Trivial patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
23.11.00
Circulation function:
Attachments: Bug 34351: Add link to access_url
Bug 34351: Add link to access_url
Bug 34351: Add link to access_url

Description Pedro Amorim 2023-07-24 10:23:05 UTC

    
Comment 1 Pedro Amorim 2023-07-24 10:24:03 UTC
Created attachment 153832 [details] [review]
Bug 34351: Add link to access_url

On k-t-d
1) Run bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh)
2) Create a new Freeform request
3) Update access_url field. Run this mysql query:
update illrequests set accessurl = https://koha-community.org/;
4) Visit ill table list at /cgi-bin/koha/ill/ill-requests.pl
5) Verify access url is not clickable
6) Apply patch. Refresh. Verify it's now clickable.
Comment 2 Pedro Amorim 2023-07-24 16:07:33 UTC
Created attachment 153848 [details] [review]
Bug 34351: Add link to access_url

On k-t-d
1) Run bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh)
2) Create a new Freeform request
3) Update access_url field. Run this mysql query:
update illrequests set accessurl = https://koha-community.org/;
4) Visit ill table list at /cgi-bin/koha/ill/ill-requests.pl
5) Verify access url is not clickable
6) Apply patch. Refresh. Verify it's now clickable.

Signed-off by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk>
Comment 3 Katrin Fischer 2023-07-31 20:29:50 UTC
Created attachment 154115 [details] [review]
Bug 34351: Add link to access_url

On k-t-d
1) Run bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh)
2) Create a new Freeform request
3) Update access_url field. Run this mysql query:
update illrequests set accessurl = https://koha-community.org/;
4) Visit ill table list at /cgi-bin/koha/ill/ill-requests.pl
5) Verify access url is not clickable
6) Apply patch. Refresh. Verify it's now clickable.

Signed-off by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Tomás Cohen Arazi (tcohen) 2023-08-15 12:20:17 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 5 Fridolin Somers 2023-08-17 20:25:09 UTC
Enhancement not pushed to 23.05.x