| Summary: | Accounting transactions should show managing librarian info for credits/debits | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Lucas Gass (lukeg) <lucas> |
| Component: | Fines and fees | Assignee: | Lucas Gass (lukeg) <lucas> |
| Status: | CLOSED FIXED | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | fridolin.somers, martin.renvoize |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
23.11.00
|
|
| Circulation function: | |||
| Attachments: |
Bug 34377: Add managing librarain
Bug 34377: Add managing librarain Bug 34377: (follow-up) Use patron-title include Bug 34377: Add managing librarain Bug 34377: (follow-up) Use patron-title include |
||
|
Description
Lucas Gass (lukeg)
2023-07-25 16:24:31 UTC
My mistake. Where the managing librarian is needed is in the Details of debit/credit table. Created attachment 155345 [details] [review] Bug 34377: Add managing librarain 1. From the patron Accounting tab > "Create manual credit". 2. From the patron Accounting tab > "Create manua 3. Go to the Transaction tab (members/boraccount.pl) and click the 'Details' button. 4. Do this for both a debit and a credit. 5. No info. about which librarain administered the credit/debit. 6. Apply patch 7. Try 3 -6 again, notice the table now shows which librarian administed the credit/debit. You construct the name display here manually.. don't we have an include for that to ensure consistency? Created attachment 155379 [details] [review] Bug 34377: Add managing librarain 1. From the patron Accounting tab > "Create manual credit". 2. From the patron Accounting tab > "Create manua 3. Go to the Transaction tab (members/boraccount.pl) and click the 'Details' button. 4. Do this for both a debit and a credit. 5. No info. about which librarain administered the credit/debit. 6. Apply patch 7. Try 3 -6 again, notice the table now shows which librarian administed the credit/debit. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 155380 [details] [review] Bug 34377: (follow-up) Use patron-title include This switched the existing manual handling of patron title construction to use the accepted include method. I signed off and added a follow-up to convert to using the aforementioned include. I'm confused by that include.. it requires `hide_patron_infos_if_needed => 1` is passed to allow a link to be created. In this case, we're looking at a librarian, I sort of feel like we should be able to override the hide but that would nuke the link which would be a regression I believe. Anywho.. it's looking good to me now. (In reply to Martin Renvoize from comment #6) > I signed off and added a follow-up to convert to using the aforementioned > include. > > I'm confused by that include.. it requires `hide_patron_infos_if_needed => > 1` is passed to allow a link to be created. In this case, we're looking at a > librarian, I sort of feel like we should be able to override the hide but > that would nuke the link which would be a regression I believe. > > Anywho.. it's looking good to me now. Thank you, Martin! Created attachment 157234 [details] [review] Bug 34377: Add managing librarain 1. From the patron Accounting tab > "Create manual credit". 2. From the patron Accounting tab > "Create manua 3. Go to the Transaction tab (members/boraccount.pl) and click the 'Details' button. 4. Do this for both a debit and a credit. 5. No info. about which librarain administered the credit/debit. 6. Apply patch 7. Try 3 -6 again, notice the table now shows which librarian administed the credit/debit. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 157235 [details] [review] Bug 34377: (follow-up) Use patron-title include This switched the existing manual handling of patron title construction to use the accepted include method. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Tiny rebase.. deciding to upgrade my SO to a PQA as the patch is trivial, clear and QA scripts are happy. Thank you, Martin! Pushed to master for 23.11. Nice work everyone, thanks! Enhancement not pushed to 23.05.x |