| Summary: | Reindent facets.inc | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | fridolin.somers |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
23.11.00
|
|
| Circulation function: | |||
| Attachments: |
Bug 34422: Reindent factets.inc
Bug 34422: (follow-up) Add markup comments Bug 34422: (follow-up) Add markup comments Bug 34422: Reindent factets.inc Bug 34422: (follow-up) Add markup comments Bug 34422: Reindent factets.inc Bug 34422: (follow-up) Add markup comments Bug 34422: Reindent factets.inc Bug 34422: (follow-up) Add markup comments Bug 34422: Reindent factets.inc Bug 34422: (follow-up) Add markup comments |
||
|
Description
Owen Leonard
2023-07-26 16:35:12 UTC
Created attachment 153930 [details] [review] Bug 34422: Reindent factets.inc This patch reindents the staff interface catalog search results facets template so that it has consistent indentation. These changes should have no visible effect on the page. To test, apply the patch and perform a catalog search in the staff interface.The facets should look the same as always. Viewing the diff while ignoring whitespace changes should show only places where a line break was added. Created attachment 153931 [details] [review] Bug 34422: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Created attachment 154080 [details] [review] Bug 34422: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Created attachment 154081 [details] [review] Bug 34422: Reindent factets.inc This patch reindents the staff interface catalog search results facets template so that it has consistent indentation. These changes should have no visible effect on the page. To test, apply the patch and perform a catalog search in the staff interface.The facets should look the same as always. Viewing the diff while ignoring whitespace changes should show only places where a line break was added. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Created attachment 154082 [details] [review] Bug 34422: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Created attachment 154700 [details] [review] Bug 34422: Reindent factets.inc This patch reindents the staff interface catalog search results facets template so that it has consistent indentation. These changes should have no visible effect on the page. To test, apply the patch and perform a catalog search in the staff interface.The facets should look the same as always. Viewing the diff while ignoring whitespace changes should show only places where a line break was added. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Created attachment 154701 [details] [review] Bug 34422: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Can you please rebase? Created attachment 157272 [details] [review] Bug 34422: Reindent factets.inc This patch reindents the staff interface catalog search results facets template so that it has consistent indentation. These changes should have no visible effect on the page. To test, apply the patch and perform a catalog search in the staff interface.The facets should look the same as always. Viewing the diff while ignoring whitespace changes should show only places where a line break was added. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Created attachment 157273 [details] [review] Bug 34422: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Created attachment 157572 [details] [review] Bug 34422: Reindent factets.inc This patch reindents the staff interface catalog search results facets template so that it has consistent indentation. These changes should have no visible effect on the page. To test, apply the patch and perform a catalog search in the staff interface.The facets should look the same as always. Viewing the diff while ignoring whitespace changes should show only places where a line break was added. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 157573 [details] [review] Bug 34422: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 23.11. Nice work everyone, thanks! Enhancement not pushed to 23.05.x |