Summary: | Some breadcrumbs lack <span> for translatability | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
Severity: | normal | ||
Priority: | P5 - low | CC: | fridolin.somers |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | String patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
23.11.00,23.05.04,22.11.10
|
|
Circulation function: | |||
Attachments: |
Bug 34436: Some breadcrumbs lack <span> for translatability
Bug 34436: Some breadcrumbs lack <span> for translatability Bug 34436: Some breadcrumbs lack <span> for translatability Bug 34436: (QA follow-up) Move spans to surround full text |
Description
Owen Leonard
2023-07-27 16:09:53 UTC
Created attachment 153996 [details] [review] Bug 34436: Some breadcrumbs lack <span> for translatability This patch modifies several templates which were updated recently so that breadcrumbs markup could be built using template wrappers. The patch wraps strings in <span> in cases where it is necessary to make them translatable. To test, apply the patch and view the following pages to confirm that the breadcrumbs still show up correctly: - Administration -> MARC bibliographic framework - Add framework - Edit framework - Delete framework - Administration -> Share content with Mana KB - Administration -> Circulation and fine rules - Authorities -> - Add authority - Edit authority - Catalog -> Advanced search - Bibliographic detail page - Must have EasyAnalyticalRecords enabled. - Edit -> Link to host record - Patrons - Reports -> Average loan time - Serials -> Serials home Created attachment 154128 [details] [review] Bug 34436: Some breadcrumbs lack <span> for translatability This patch modifies several templates which were updated recently so that breadcrumbs markup could be built using template wrappers. The patch wraps strings in <span> in cases where it is necessary to make them translatable. To test, apply the patch and view the following pages to confirm that the breadcrumbs still show up correctly: - Administration -> MARC bibliographic framework - Add framework - Edit framework - Delete framework - Administration -> Share content with Mana KB - Administration -> Circulation and fine rules - Authorities -> - Add authority - Edit authority - Catalog -> Advanced search - Bibliographic detail page - Must have EasyAnalyticalRecords enabled. - Edit -> Link to host record - Patrons - Reports -> Average loan time - Serials -> Serials home Signed-off-by: Sam Lau <samalau@gmail.com> Created attachment 154133 [details] [review] Bug 34436: Some breadcrumbs lack <span> for translatability This patch modifies several templates which were updated recently so that breadcrumbs markup could be built using template wrappers. The patch wraps strings in <span> in cases where it is necessary to make them translatable. To test, apply the patch and view the following pages to confirm that the breadcrumbs still show up correctly: - Administration -> MARC bibliographic framework - Add framework - Edit framework - Delete framework - Administration -> Share content with Mana KB - Administration -> Circulation and fine rules - Authorities -> - Add authority - Edit authority - Catalog -> Advanced search - Bibliographic detail page - Must have EasyAnalyticalRecords enabled. - Edit -> Link to host record - Patrons - Reports -> Average loan time - Serials -> Serials home Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 154134 [details] [review] Bug 34436: (QA follow-up) Move spans to surround full text Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> - Delete framework for [% framework.frameworktext | html %] ([% framework.frameworkcode | html %])? + <span>Delete framework for [% framework.frameworktext | html %]</span> ([% framework.frameworkcode | html %])? The span should be after the ? because you might have a different sentence structure for a question. Pushed to master for 23.11. Nice work everyone, thanks! Pushed to 23.05.x for 23.05.04 Nice work everyone! Pushed to oldstable for 22.11.x |